Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant Warn log in HTTP codec. (#18699) #18702

Merged
merged 4 commits into from
Oct 29, 2021
Merged

Remove redundant Warn log in HTTP codec. (#18699) #18702

merged 4 commits into from
Oct 29, 2021

Conversation

ankatare
Copy link
Contributor

This line was introduced in efcf2e5, but it is flooding the log outputs of Envoy users, so this PR just deletes the line. For detail, please refer to #18643.

Signed-off-by: Takeshi Yoneda takeshi@tetrate.io
Signed-off-by: Abhay Narayan Katare abhay.katare@india.nec.com

Commit Message: Remove redundant Warn log in HTTP codec (Backport from #18699)
Fixes #18643

@ankatare
Copy link
Contributor Author

@mathetake PTAL

@mathetake
Copy link
Member

Thanks, code LGTM, but we have to wait until #18658 has landed to have clean commit tree.

/wait

@ankatare
Copy link
Contributor Author

Ok. Thanks

@htuch htuch self-assigned this Oct 21, 2021
@mathetake
Copy link
Member

mathetake commented Oct 27, 2021 •
edited
Loading

#18658 has landed, so could you rebase and add the release note? @ankatare

@mathetake mathetake mentioned this pull request Oct 27, 2021
Merged
@ankatare
Copy link
Contributor Author

@mathetake Would you plesse

#18658 has landed, so could you rebase and add the release note? @ankatare

Hi @mathetake that need to be on top of envoyproxy:release/v.20.0, right ?

@mathetake
Copy link
Member

mathetake commented Oct 27, 2021 •
edited
Loading

Should be in https://github.com/envoyproxy/envoy/blob/release/v1.20/docs/root/version_history/current.rst in this PR

@ankatare
Copy link
Contributor Author

Should be in https://github.com/envoyproxy/envoy/blob/release/v1.20/docs/root/version_history/current.rst in this PR

yeah... i meant the same :) . One quick thing.. should i create new PR for Release note or do doc changes in same PR ?

@mathetake
Copy link
Member

As I said in this PR. See #18782

@ankatare
Copy link
Contributor Author

As I said in this PR. See #18782

Ok

mathetake and others added 2 commits October 27, 2021 16:24
@mathetake @ankatare
Remove redundant Warn log in HTTP codec. (envoyproxy#18699)
2b150d8 
This line was introduced in efcf2e5, but it is flooding the log outputs of Envoy users, so this PR just deletes the line. For detail, please refer to envoyproxy#18643.

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
@ankatare
Adding release note for PR envoyproxy#18702
b736090 
Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
mathetake
mathetake suggested changes Oct 27, 2021
View reviewed changes
Copy link
Member

@mathetake mathetake left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs base branch merge.

@ankatare
Copy link
Contributor Author

Needs base branch merge.

Anything pending here. Sorry, i did not get.

@mathetake
Copy link
Member

Needs base branch merge.

Anything pending here. Sorry, i did not get.

You can see the conflict with the base branch so you need to resolve that.

@ankatare
fix build issues
ff41917 
Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
@ankatare
Copy link
Contributor Author

Needs base branch merge.

Anything pending here. Sorry, i did not get.

You can see the conflict with the base branch so you need to resolve that.

Done. Thanks for review it

mathetake
mathetake approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mathetake
Copy link
Member

Pass to @htuch for final review

@ankatare
ïncorporating review comments by htuch on doc
a91af21 
Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
@htuch htuch merged commit 9d581d2 into envoyproxy:release/v1.20 Oct 29, 2021
@ankatare ankatare mentioned this pull request Dec 16, 2021
Closed
aidanhahn pushed a commit to datawire/envoy that referenced this pull request Jan 13, 2022
@ankatare @mathetake @aidanhahn
Remove redundant Warn log in HTTP codec. (envoyproxy#18699) (envoypro…
c29d7bb 
…xy#18702)

This line was introduced in efcf2e5, but it is flooding the log outputs of Envoy users, so this PR just deletes the line. For detail, please refer to envoyproxy#18643.

Fixes envoyproxy#18643

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
Co-authored-by: Takeshi Yoneda <takeshi@tetrate.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htuch htuch htuch approved these changes

@mathetake mathetake mathetake approved these changes

Assignees

@htuch htuch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ankatare @mathetake @htuch