Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 1.20]:listen socket factory can be cloned from listener draining … #18782

Merged
merged 3 commits into from
Oct 27, 2021
Merged

[Backport 1.20]:listen socket factory can be cloned from listener draining … #18782

merged 3 commits into from
Oct 27, 2021

Conversation

lambdai
Copy link
Contributor

@lambdai lambdai commented Oct 26, 2021

…… (#18686)

Commit Message:
Backport 6f0ecc5 to 1.2-

Signed-off-by: Yuchen Dai silentdai@gmail.com

Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@lambdai
Copy link
Contributor Author

lambdai commented Oct 26, 2021

The precheck docs is unrelated. Can we ignore @mathetake

@lambdai
Copy link
Contributor Author

lambdai commented Oct 26, 2021

/assign @mathetake

@lambdai
Copy link
Contributor Author

lambdai commented Oct 26, 2021

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18782 (comment) was created by @lambdai.

see: more, trace.

mathetake
mathetake reviewed Oct 27, 2021
View reviewed changes
Copy link
Member

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we should wait for #18658 to land and I would like you to add release note here (cc @lizan)

@mathetake
Copy link
Member

#18658 has landed so could you rebase and add the release note? @lambdai

@lambdai
Merge remote-tracking branch 'origin/release/v1.20' into bp_listensoc…
5b24f71 
…ket_track

Signed-off-by: Yuchen Dai <silentdai@gmail.com>
@lambdai
add release log
ff6a8cd 
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
@lambdai
Copy link
Contributor Author

lambdai commented Oct 27, 2021

@mathetake Thanks! Added one

@mathetake
Copy link
Member

Will merge when CI becomes happy

@mathetake
Copy link
Member

@lambdai jfyi you maybe want to also include #18702 for istio freeze :D

@mathetake mathetake mentioned this pull request Oct 27, 2021
Merged
@mathetake mathetake merged commit 614ac4f into envoyproxy:release/v1.20 Oct 27, 2021
@lambdai lambdai deleted the bp_listensocket_track branch October 27, 2021 16:10
@lambdai
Copy link
Contributor Author

lambdai commented Oct 27, 2021

@mathetake Thanks! That's a release blocker for sure. Fortunately it's not a test blocker

@ericvn ericvn mentioned this pull request Oct 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathetake mathetake mathetake approved these changes

Assignees

@mathetake mathetake

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lambdai @mathetake