stats: allow configurable flush interval #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep the default at 5s.
|
@lyft/network-team @lyft/observability |
ccaraman
approved these changes
Dec 2, 2016
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
PiotrSikora
referenced
this pull request
in istio/envoy
Nov 1, 2019
We don't need it anymore. Missed in #260. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
lambdai
pushed a commit
to lambdai/envoy-dai
that referenced
this pull request
Mar 11, 2021
* Apply patch 2 * patch 3 * Patch 4 * Fixing build failures Co-authored-by: Dmitri Dolguikh <ddolguik@redhat.com> Co-authored-by: Dmitri Dolguikh <ddolguik@redhat.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Because `RetryPolicy` inherits from `NSObject` in order to be visible to Objective-C, we need to implement our own equatable comparison in order for `==` to work as intended (using property comparison instead of pointer comparison). Adds tests to verify this. Signed-off-by: Michael Rebello <mrebello@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Because `RetryPolicy` inherits from `NSObject` in order to be visible to Objective-C, we need to implement our own equatable comparison in order for `==` to work as intended (using property comparison instead of pointer comparison). Adds tests to verify this. Signed-off-by: Michael Rebello <mrebello@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
arminabf
pushed a commit
to arminabf/envoy
that referenced
this pull request
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep the default at 5s.