oauth2: refactor SDS secret provider to remove a data race #32625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Idd4b05fe698b27e03a773e7dfe27c251842e3e55 Signed-off-by: Kuat Yessenov <kuat@google.com>
|
FYI @zhaohuabing , since the code was duplicated in #30850 |
kyessenov
commented
Feb 28, 2024
| @@ -162,6 +162,7 @@ paths: | |||
| - source/common/upstream/health_discovery_service.cc | |||
| - source/common/secret/sds_api.h | |||
| - source/common/secret/sds_api.cc | |||
| - source/common/secret/secret_provider_impl.cc | |||
There was a problem hiding this comment.
Not feasible to exclude it until SDS stops using exceptions in callbacks.
|
/retest |
1 similar comment
|
/retest |
mattklein123
approved these changes
Feb 29, 2024
mum4k
pushed a commit
to envoyproxy/nighthawk
that referenced
this pull request
Mar 5, 2024
- Update the ENVOY_COMMIT and ENVOY_SHA in bazel/repositories.bzl to the latest Envoy's commit. - Update to .bazelrc and tools/gen_compilation_database.py to envoyproxy/envoy#32585 - Update source/client/process_impl.cc to accommodate refactor in envoyproxy/envoy#32587 - Update tools/code_format/config.yaml for changes in envoyproxy/envoy#32625 and envoyproxy/envoy#32252 - Update python dependencies - Ensure ostream_formatter definitions are before usage to prevent "explicit specialization of X after instantiation" errors Signed-off-by: Tom Zhang <4367421+tomjzzhang@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Idd4b05fe698b27e03a773e7dfe27c251842e3e55
Commit Message: Refactor SDS secret provider to use TLV for values and make it a common utility to prevent code duplication.
Additional Description:
Risk Level: low
Testing: done
Docs Changes: none
Release Notes: none
Fixes: #21273