c++20 by default #32585

kyessenov · 2024-02-26T19:14:37Z

Change-Id: Ia1908ecdcbf514638bb62807863420cdebacb9df

Commit Message: Update all builds except mobile to use C++20 language reference.
Additional Description:
Risk Level: medium
Testing: done
Docs Changes: none
Release Notes: none

Change-Id: Ia1908ecdcbf514638bb62807863420cdebacb9df Signed-off-by: Kuat Yessenov <kuat@google.com>

repokitteh-read-only · 2024-02-26T19:14:45Z

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @RyanTheOptimist

🐱

Caused by: #32585 was opened by kyessenov.

see: more, trace.

Change-Id: I8aaf137601c92e7a9a87ded43693b86f0945d9c7 Signed-off-by: Kuat Yessenov <kuat@google.com>

Change-Id: I85da5b74dde0c64e9f467f9600e8020971e6e684 Signed-off-by: Kuat Yessenov <kuat@google.com>

Change-Id: I1cc53913d7b66293bb6ff7c5d8c837917fb79b4e Signed-off-by: Kuat Yessenov <kuat@google.com>

RyanTheOptimist

LGTM, assuming we can sort out CI!

Change-Id: I88d490addcc68ae8508b29fec2505f906aedb1fd Signed-off-by: Kuat Yessenov <kuat@google.com>

Change-Id: I4b919b0aa8774458e4efe39d91603d28e6a649bc Signed-off-by: Kuat Yessenov <kuat@google.com>

Change-Id: I98a310a30a7664a2512be110ead21b245ae7d126 Signed-off-by: Kuat Yessenov <kuat@google.com>

This reverts commit badd720. Change-Id: I1d5eb6c3427e467367fdde378abb28dada2d7991 Signed-off-by: Kuat Yessenov <kuat@google.com>

Change-Id: I181a9d3aeeb3c89137048c8a9d9ff74d8c61ad25 Signed-off-by: Kuat Yessenov <kuat@google.com>

Change-Id: Icd5325d65a1de6e8f67a546b1afda697a85e9501 Signed-off-by: Kuat Yessenov <kuat@google.com>

Change-Id: I24f648d496808e65926389ff6f1c3b3735adef41

Change-Id: Ia6a40ca21602c2cd726ea43c0a93ee3f99811647 Signed-off-by: Kuat Yessenov <kuat@google.com>

RyanTheOptimist · 2024-02-28T05:08:54Z

/wait on CI

Change-Id: Iff80bafd95591618c586e8c61b0084af4bd4557a

kyessenov · 2024-02-28T23:09:10Z

/retest

kyessenov · 2024-02-28T23:59:11Z

So close! gcc and android NDK are the last two standing.

Change-Id: Iac3690e3eee10e16f7679f1524e2f3c1835bbf96 Signed-off-by: Kuat Yessenov <kuat@google.com>

Change-Id: I5ae73de42a93b5b17b948d2d17a10f8b075faca9 Signed-off-by: Kuat Yessenov <kuat@google.com>

kyessenov · 2024-02-29T17:06:08Z

GCC done. Only NDK remains.

Change-Id: Id663fb0a88a9eb2968a86539054f7ef87aa518e6

Change-Id: Ie7538fb6c6a62b8c221cad51e4a4986753119a17 Signed-off-by: Kuat Yessenov <kuat@google.com>

Change-Id: I162b3c89507e4ac7340836a3f89c1cb55ae0d850 Signed-off-by: Kuat Yessenov <kuat@google.com>

Change-Id: I09432434403c924d433051f1ace208c533a28993 Signed-off-by: Kuat Yessenov <kuat@google.com>

Change-Id: Ic33826545f4528f4f26caf9d9f06e93079cf2a9f Signed-off-by: Kuat Yessenov <kuat@google.com>

kyessenov · 2024-02-29T23:14:27Z

https://github.com/envoyproxy/envoy/actions/runs/8103764117 confirms c++17 restriction works on Android build and rejects C++20 constructs.

Change-Id: I12c9ab575960ac69bf1e65baf5374932cacbfbbf Signed-off-by: Kuat Yessenov <kuat@google.com>

RyanTheOptimist

LGTM, modulo a couple of nits

RyanTheOptimist · 2024-02-29T17:09:08Z

bazel/cel-cpp.patch

+-  static_assert(std::is_pointer_interconvertible_base_of_v<Data, F>,
+-                "F must be pointer interconvertible to Data");
+//  static_assert(std::is_pointer_interconvertible_base_of_v<Data, F>,
+//                "F must be pointer interconvertible to Data");


Should we remove the "//"?

I plan to update cel-cpp immediately and get rid of this patch or fix it upstream. I can't tell if this is a real issue or not with GCC.

RyanTheOptimist · 2024-03-01T21:13:30Z

bazel/proxy_wasm_cpp_sdk.patch

+
+-  Counter<Tags...>(std::string_view name, MetricTagDescriptor<Tags>... descriptors)
+-      : Counter<Tags...>(std::string(name), std::vector<MetricTag>({toMetricTag(descriptors)...})) {
+  template <typename... T>


Is proxy_wasm_api incompatible with C++20?

No, this is just some helper AFAICT which is only used in one place in a test.

RyanTheOptimist · 2024-03-01T21:15:23Z

source/extensions/access_loggers/grpc/grpc_access_log_utils.cc

@@ -271,7 +271,14 @@ void Utility::extractCommonAccessLogProperties(
  }

  if (stream_info.upstreamInfo().has_value()) {
+#if defined(__GNUC__) && !defined(__clang__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdangling-reference"


Looks like we have quite a few of these. Is -Wdangling-reference finding false positives? Should we consider just disabling this warning in our build globally?

Yes, gcc implementation is buggy, you can find reports in other projects. The pattern here is unusual but the same, so maybe better keep it since we know when the false positive happens.

* main: (151 commits) http3: fixing an upstream threading issue and bumping http3 upstream code back to alpha (envoyproxy#32640) rlqs: reset quota usage (envoyproxy#32569) proxy status: add more mapping to proxystatus (envoyproxy#32606) rlqs: add logging around token bucket (envoyproxy#32612) Logging: ENVOY_BUG include filter name. (envoyproxy#32663) mobile: Reenable the FilterIntegrationTest.AltSvcCachedH2Slow test (envoyproxy#32675) c++20 by default (envoyproxy#32585) Docs: Add diagram for histogram stat sink. (envoyproxy#32665) Fix null node for list of struct in payload_to_metadaata filter (envoyproxy#32309) metrics_service: populate histogram summary sample sum (envoyproxy#32666) build(deps): bump postgres from `0e564da` to `f58300a` in /examples/shared/postgres (envoyproxy#32632) build(deps): bump the examples-ext-authz group in /examples/ext_authz with 1 update (envoyproxy#32654) build(deps): bump distroless/base-nossl-debian12 from `28dc895` to `0e777c6` in /ci (envoyproxy#32652) Update QUICHE from 02047e04d to 3373df94b (envoyproxy#32650) ci/logging: Add failure detection (envoyproxy#32662) Change udpa renaming workaround to not compile the same archive twice (envoyproxy#32647) sockets: flipping graceful client socket creation failure (envoyproxy#32602) TcpAsyncClient: enhance reconnect robustness (envoyproxy#32578) owners: adding Fredy as an Enovy Mobile maintainer (envoyproxy#32638) ci: Add scheduled garbage collection (and fix retest) (envoyproxy#32639) ...

- Update the ENVOY_COMMIT and ENVOY_SHA in bazel/repositories.bzl to the latest Envoy's commit. - Update to .bazelrc and tools/gen_compilation_database.py to envoyproxy/envoy#32585 - Update source/client/process_impl.cc to accommodate refactor in envoyproxy/envoy#32587 - Update tools/code_format/config.yaml for changes in envoyproxy/envoy#32625 and envoyproxy/envoy#32252 - Update python dependencies - Ensure ostream_formatter definitions are before usage to prevent "explicit specialization of X after instantiation" errors Signed-off-by: Tom Zhang <4367421+tomjzzhang@users.noreply.github.com>

It was defaulting to C++20 due to envoyproxy#32585, but for mobile, we are still on C++17. This change enables local builds to build with C++17 without encountering toolchain errors. Signed-off-by: Ali Beyad <abeyad@google.com>

It was defaulting to C++20 due to #32585, but for mobile, we are still on C++17. This change enables local builds to build with C++17 without encountering toolchain errors. Signed-off-by: Ali Beyad <abeyad@google.com>

Added in envoyproxy/envoy#32585. Required for proxy-wasm/proxy-wasm-cpp-host#411 Signed-off-by: Matt Leon <mattleon@google.com>

c++20 by default

f5e7024

Change-Id: Ia1908ecdcbf514638bb62807863420cdebacb9df Signed-off-by: Kuat Yessenov <kuat@google.com>

kyessenov requested review from RyanTheOptimist, alyssawilk and abeyad as code owners February 26, 2024 19:14

repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Feb 26, 2024

repokitteh-read-only bot assigned RyanTheOptimist Feb 26, 2024

kyessenov added 3 commits February 26, 2024 19:16

oops

4e052d2

Change-Id: I8aaf137601c92e7a9a87ded43693b86f0945d9c7 Signed-off-by: Kuat Yessenov <kuat@google.com>

fixes

c5c4558

Change-Id: I85da5b74dde0c64e9f467f9600e8020971e6e684 Signed-off-by: Kuat Yessenov <kuat@google.com>

fix compilation issue

9be7455

Change-Id: I1cc53913d7b66293bb6ff7c5d8c837917fb79b4e Signed-off-by: Kuat Yessenov <kuat@google.com>

RyanTheOptimist previously approved these changes Feb 27, 2024

View reviewed changes

fix mobile

f22aed8

Change-Id: I88d490addcc68ae8508b29fec2505f906aedb1fd Signed-off-by: Kuat Yessenov <kuat@google.com>

kyessenov dismissed RyanTheOptimist’s stale review via f22aed8 February 27, 2024 05:50

kyessenov added 7 commits February 27, 2024 19:52

wip

badd720

Change-Id: I4b919b0aa8774458e4efe39d91603d28e6a649bc Signed-off-by: Kuat Yessenov <kuat@google.com>

patch sdk

f3efb0c

Change-Id: I98a310a30a7664a2512be110ead21b245ae7d126 Signed-off-by: Kuat Yessenov <kuat@google.com>

Revert "wip"

a8a119f

This reverts commit badd720. Change-Id: I1d5eb6c3427e467367fdde378abb28dada2d7991 Signed-off-by: Kuat Yessenov <kuat@google.com>

attempt to fix mobile

875f5ba

Change-Id: I181a9d3aeeb3c89137048c8a9d9ff74d8c61ad25 Signed-off-by: Kuat Yessenov <kuat@google.com>

fix

f8df3bb

Change-Id: Icd5325d65a1de6e8f67a546b1afda697a85e9501 Signed-off-by: Kuat Yessenov <kuat@google.com>

Merge remote-tracking branch 'upstream/main' into cpp20

6075777

Change-Id: I24f648d496808e65926389ff6f1c3b3735adef41

bump NDK

2d0399a

Change-Id: Ia6a40ca21602c2cd726ea43c0a93ee3f99811647 Signed-off-by: Kuat Yessenov <kuat@google.com>

kyessenov requested a review from lizan as a code owner February 27, 2024 21:43

repokitteh-read-only bot added the waiting label Feb 28, 2024

Merge remote-tracking branch 'upstream/main' into cpp20

df07980

Change-Id: Iff80bafd95591618c586e8c61b0084af4bd4557a

gcc fixes

fbc2054

Change-Id: Iac3690e3eee10e16f7679f1524e2f3c1835bbf96 Signed-off-by: Kuat Yessenov <kuat@google.com>

kyessenov requested review from zuercher, wbpcode and mattklein123 as code owners February 29, 2024 06:30

kyessenov requested a review from yanavlasov as a code owner February 29, 2024 06:30

repokitteh-read-only bot removed the waiting label Feb 29, 2024

clang wants gcc pragmas

947e3a4

Change-Id: I5ae73de42a93b5b17b948d2d17a10f8b075faca9 Signed-off-by: Kuat Yessenov <kuat@google.com>

kyessenov added 5 commits February 29, 2024 19:51

Merge remote-tracking branch 'upstream/main' into cpp20

d07557e

Change-Id: Id663fb0a88a9eb2968a86539054f7ef87aa518e6

revert for mobile

6d21545

Change-Id: Ie7538fb6c6a62b8c221cad51e4a4986753119a17 Signed-off-by: Kuat Yessenov <kuat@google.com>

oops

433e6a2

Change-Id: I162b3c89507e4ac7340836a3f89c1cb55ae0d850 Signed-off-by: Kuat Yessenov <kuat@google.com>

nothing

1c66e35

Change-Id: I09432434403c924d433051f1ace208c533a28993 Signed-off-by: Kuat Yessenov <kuat@google.com>

test c++20 on mobile

b536ffe

Change-Id: Ic33826545f4528f4f26caf9d9f06e93079cf2a9f Signed-off-by: Kuat Yessenov <kuat@google.com>

revert

fe4d13a

Change-Id: I12c9ab575960ac69bf1e65baf5374932cacbfbbf Signed-off-by: Kuat Yessenov <kuat@google.com>

RyanTheOptimist reviewed Mar 1, 2024

View reviewed changes

RyanTheOptimist approved these changes Mar 1, 2024

View reviewed changes

repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Mar 1, 2024

kyessenov merged commit 11d79fe into envoyproxy:main Mar 4, 2024
54 checks passed

kyessenov deleted the cpp20 branch March 4, 2024 17:31

tomjzzhang mentioned this pull request Mar 5, 2024

Update Envoy to e28e0d6 (Mar 05, 2024) envoyproxy/nighthawk#1091

Merged

abeyad mentioned this pull request Mar 21, 2024

mobile: Force mobile-release-common build to use C++17 #33047

Merged

ashishb-solo mentioned this pull request May 3, 2024

Update to v1.30 solo-io/envoy-gloo#333

Merged

leonm1 added a commit to proxy-wasm/proxy-wasm-cpp-sdk that referenced this pull request Jan 7, 2025

build: Upstream envoy's C++20 patch

3f9a434

Added in envoyproxy/envoy#32585. Required for proxy-wasm/proxy-wasm-cpp-host#411 Signed-off-by: Matt Leon <mattleon@google.com>

leonm1 mentioned this pull request Jan 7, 2025

build: Upstream envoy's C++20 patch proxy-wasm/proxy-wasm-cpp-sdk#181

Merged

leonm1 added a commit to leonm1/proxy-wasm-cpp-sdk that referenced this pull request Jan 7, 2025

build: Upstream envoy's C++20 patch

22914ee

Added in envoyproxy/envoy#32585. Required for proxy-wasm/proxy-wasm-cpp-host#411 Signed-off-by: Matt Leon <mattleon@google.com>

leonm1 added a commit to leonm1/proxy-wasm-cpp-sdk that referenced this pull request Jan 7, 2025

build: Upstream envoy's C++20 patch

88a8b6f

Added in envoyproxy/envoy#32585. Required for proxy-wasm/proxy-wasm-cpp-host#411 Signed-off-by: Matt Leon <mattleon@google.com>

mpwarres pushed a commit to proxy-wasm/proxy-wasm-cpp-sdk that referenced this pull request Jan 7, 2025

build: Upstream envoy's C++20 patch (#181)

4f53e7a

Added in envoyproxy/envoy#32585. Required for proxy-wasm/proxy-wasm-cpp-host#411 Signed-off-by: Matt Leon <mattleon@google.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

c++20 by default #32585

c++20 by default #32585

kyessenov commented Feb 26, 2024 •

edited

Loading

repokitteh-read-only bot commented Feb 26, 2024

RyanTheOptimist left a comment

RyanTheOptimist commented Feb 28, 2024

kyessenov commented Feb 28, 2024

kyessenov commented Feb 28, 2024

kyessenov commented Feb 29, 2024

kyessenov commented Feb 29, 2024

RyanTheOptimist left a comment

RyanTheOptimist Feb 29, 2024

kyessenov Mar 1, 2024

RyanTheOptimist Mar 1, 2024

kyessenov Mar 1, 2024

RyanTheOptimist Mar 1, 2024

kyessenov Mar 1, 2024

c++20 by default #32585

c++20 by default #32585

Conversation

kyessenov commented Feb 26, 2024 • edited Loading

repokitteh-read-only bot commented Feb 26, 2024

RyanTheOptimist left a comment

Choose a reason for hiding this comment

RyanTheOptimist commented Feb 28, 2024

kyessenov commented Feb 28, 2024

kyessenov commented Feb 28, 2024

kyessenov commented Feb 29, 2024

kyessenov commented Feb 29, 2024

RyanTheOptimist left a comment

Choose a reason for hiding this comment

RyanTheOptimist Feb 29, 2024

Choose a reason for hiding this comment

kyessenov Mar 1, 2024

Choose a reason for hiding this comment

RyanTheOptimist Mar 1, 2024

Choose a reason for hiding this comment

kyessenov Mar 1, 2024

Choose a reason for hiding this comment

RyanTheOptimist Mar 1, 2024

Choose a reason for hiding this comment

kyessenov Mar 1, 2024

Choose a reason for hiding this comment

kyessenov commented Feb 26, 2024 •

edited

Loading