Change udpa renaming workaround to not compile the same archive twice #32647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raven Black <ravenblack@dropbox.com>
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
|
/retest |
Signed-off-by: Raven Black <ravenblack@dropbox.com>
repokitteh-read-only
bot
removed
the
deps
repokitteh-read-only
bot
added
the
deps
phlax
approved these changes
Mar 1, 2024
repokitteh-read-only
bot
removed
the
deps
mattjo
added a commit
to mattjo/envoy
that referenced
this pull request
Mar 5, 2024
* main: (151 commits) http3: fixing an upstream threading issue and bumping http3 upstream code back to alpha (envoyproxy#32640) rlqs: reset quota usage (envoyproxy#32569) proxy status: add more mapping to proxystatus (envoyproxy#32606) rlqs: add logging around token bucket (envoyproxy#32612) Logging: ENVOY_BUG include filter name. (envoyproxy#32663) mobile: Reenable the FilterIntegrationTest.AltSvcCachedH2Slow test (envoyproxy#32675) c++20 by default (envoyproxy#32585) Docs: Add diagram for histogram stat sink. (envoyproxy#32665) Fix null node for list of struct in payload_to_metadaata filter (envoyproxy#32309) metrics_service: populate histogram summary sample sum (envoyproxy#32666) build(deps): bump postgres from `0e564da` to `f58300a` in /examples/shared/postgres (envoyproxy#32632) build(deps): bump the examples-ext-authz group in /examples/ext_authz with 1 update (envoyproxy#32654) build(deps): bump distroless/base-nossl-debian12 from `28dc895` to `0e777c6` in /ci (envoyproxy#32652) Update QUICHE from 02047e04d to 3373df94b (envoyproxy#32650) ci/logging: Add failure detection (envoyproxy#32662) Change udpa renaming workaround to not compile the same archive twice (envoyproxy#32647) sockets: flipping graceful client socket creation failure (envoyproxy#32602) TcpAsyncClient: enhance reconnect robustness (envoyproxy#32578) owners: adding Fredy as an Enovy Mobile maintainer (envoyproxy#32638) ci: Add scheduled garbage collection (and fix retest) (envoyproxy#32639) ...
Alice-Lilith
pushed a commit
to datawire/envoy
that referenced
this pull request
May 9, 2024
see: envoyproxy#32647 for details Signed-off-by: Alice Wasko <alicewasko@datawire.io>
Alice-Lilith
pushed a commit
to datawire/envoy
that referenced
this pull request
May 10, 2024
see: envoyproxy#32647 for details Signed-off-by: Alice Wasko <alicewasko@datawire.io>
tenshinhigashi
pushed a commit
to datawire/envoy
that referenced
this pull request
Jun 10, 2024
see: envoyproxy#32647 for details Signed-off-by: Alice Wasko <alicewasko@datawire.io>
Alice-Lilith
pushed a commit
to datawire/envoy
that referenced
this pull request
Jun 26, 2024
see: envoyproxy#32647 for details Signed-off-by: Alice Wasko <alicewasko@datawire.io>
Alice-Lilith
pushed a commit
to datawire/envoy
that referenced
this pull request
Sep 19, 2024
see: envoyproxy#32647 for details Signed-off-by: Alice Wasko <alicewasko@datawire.io>
tenshinhigashi
pushed a commit
to datawire/envoy
that referenced
this pull request
Nov 11, 2024
see: envoyproxy#32647 for details Signed-off-by: Alice Wasko <alicewasko@datawire.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Change udpa renaming workaround to not compile the same archive twice
Additional Description: I copied the prior workaround into a different build environment and it caused linker errors in one subset of the space, which made it clear that the repo was downloaded and compiled twice in the bazel cache under different paths. This change fixes that.
Risk Level: None - if it builds it's better.
Testing: If it builds it ships.
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a