-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TcpAsyncClient: enhance reconnect robustness #32578
Conversation
Signed-off-by: ohadvano <ohadvano@gmail.com>
/assign @botengyao |
Signed-off-by: ohadvano <ohadvano@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving this!
Signed-off-by: ohadvano <ohadvano@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/wait
Signed-off-by: ohadvano <ohadvano@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tnx for the review @ggreenway, can you merge the PR please? |
* main: (151 commits) http3: fixing an upstream threading issue and bumping http3 upstream code back to alpha (envoyproxy#32640) rlqs: reset quota usage (envoyproxy#32569) proxy status: add more mapping to proxystatus (envoyproxy#32606) rlqs: add logging around token bucket (envoyproxy#32612) Logging: ENVOY_BUG include filter name. (envoyproxy#32663) mobile: Reenable the FilterIntegrationTest.AltSvcCachedH2Slow test (envoyproxy#32675) c++20 by default (envoyproxy#32585) Docs: Add diagram for histogram stat sink. (envoyproxy#32665) Fix null node for list of struct in payload_to_metadaata filter (envoyproxy#32309) metrics_service: populate histogram summary sample sum (envoyproxy#32666) build(deps): bump postgres from `0e564da` to `f58300a` in /examples/shared/postgres (envoyproxy#32632) build(deps): bump the examples-ext-authz group in /examples/ext_authz with 1 update (envoyproxy#32654) build(deps): bump distroless/base-nossl-debian12 from `28dc895` to `0e777c6` in /ci (envoyproxy#32652) Update QUICHE from 02047e04d to 3373df94b (envoyproxy#32650) ci/logging: Add failure detection (envoyproxy#32662) Change udpa renaming workaround to not compile the same archive twice (envoyproxy#32647) sockets: flipping graceful client socket creation failure (envoyproxy#32602) TcpAsyncClient: enhance reconnect robustness (envoyproxy#32578) owners: adding Fredy as an Enovy Mobile maintainer (envoyproxy#32638) ci: Add scheduled garbage collection (and fix retest) (envoyproxy#32639) ...
Additional Description: small modifications to allow reconnecting in
TcpAsyncClient
along with testsRisk Level: low
Testing: unit tests, integration tests
Docs Changes: None
Release Notes: None
Platform Specific Features: None