Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change udpa renaming workaround to not compile the same archive twice #32647

Merged
merged 2 commits into from
Mar 1, 2024

Clarify expiry of repo_mapping

a301a6b
Select commit
Loading
Failed to load commit list.
Merged

Change udpa renaming workaround to not compile the same archive twice #32647

Clarify expiry of repo_mapping
a301a6b
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/Perf skipped Mar 1, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/32647/main@a301a6b)

phlax @phlax a301a6b #32647 merge main@28ed0f4

Change udpa renaming workaround to not compile the same archive twice

Commit Message: Change udpa renaming workaround to not compile the same archive twice
Additional Description: I copied the prior workaround into a different build environment and it caused linker errors in one subset of the space, which made it clear that the repo was downloaded and compiled twice in the bazel cache under different paths. This change fixes that.
Risk Level: None - if it builds it's better.
Testing: If it builds it ships.
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Environment

Request variables

Key Value
ref 2d0288b97006c69082306bc2715f09acbd9e13dc
sha a301a6b
pr 32647
base-sha 28ed0f4
actor phlax @phlax
message Change udpa renaming workaround to not compile the same archive twice...
started 1709307190.649129
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:0ca52447572ee105a4730da5e76fe47c9c5a7c64
mobile envoyproxy/envoy-build-ubuntu:mobile-0ca52447572ee105a4730da5e76fe47c9c5a7c64
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 30
patch 0
dev true