Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: Force mobile-release-common build to use C++17 #33047

Merged
merged 1 commit into from
Mar 21, 2024

mobile: Force mobile-release-common build to use C++17

2b312c3
Select commit
Loading
Failed to load commit list.
Merged

mobile: Force mobile-release-common build to use C++17 #33047

mobile: Force mobile-release-common build to use C++17
2b312c3
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/Perf succeeded Mar 21, 2024 in 15m 18s

Mobile/Perf (success)

Check has finished

Details

Check run finished (success ✔️)

The check run can be viewed here:

Mobile/Perf (pr/33047/main@2b312c3)

Check started by

Request (pr/33047/main@2b312c3)

abeyad @abeyad 2b312c3 #33047 merge main@d298fdc

mobile: Force mobile-release-common build to use C++17

It was defaulting to C++20 due to
#32585, but for mobile, we are still on C++17. This change enables local builds to build with C++17 without encountering toolchain errors.

Environment

Request variables

Key Value
ref 19ea3d1e0f32273d30bd9d7244e85c99bf2b7461
sha 2b312c3
pr 33047
base-sha d298fdc
actor abeyad @abeyad
message mobile: Force mobile-release-common build to use C++17...
started 1711046059.641178
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 30
patch 0
dev true