[http-cache] Don't bypass the cache for if-unmodified-since or if-match #33080
Mobile/Compile time options (success)
Check has finished
Details
Check run finished (success ✔️)
The check run can be viewed here:
Mobile/Compile time options (pr/33080/main@037b385)
Check started by
Request (pr/33080/main@037b385)
@ravenblackx 037b385
#33080 merge
main@efae60f
[http-cache] Don't bypass the catch for if-unmodified-since or if-match
Commit Message: [http-cache] Don't bypass the catch for if-unmodified-since or if-match
Additional Description: There's a whole section of the cache filter to do with conditional headers that's unimplemented ("if needed, implement it to this spec!"). Turns out we only need the very easy to implement subset, where the cache is supposed to ignore one of the conditional headers. I threw in the other one that's supposed to be ignored as well.
Risk Level: Very low, it's a WIP filter and an edge case use of it where before the change it does the wrong thing.
Testing: Doesn't even make sense to have a special test for this - there are an infinite number of headers the cache should ignore.
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
Environment
Request variables
Key | Value |
---|---|
ref | b7937e77130df3414ddbdc8ccef7fa2ed3d36120 |
sha | 037b385 |
pr | 33080 |
base-sha | efae60f |
actor | @ravenblackx |
message | [http-cache] Don't bypass the catch for if-unmodified-since or if-match... |
started | 1711140991.557613 |
target-branch | main |
trusted | false |
Build image
Container image/s (as used in this CI run)
Key | Value |
---|---|
default | envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c |
mobile | envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c |
Version
Envoy version (as used in this CI run)
Key | Value |
---|---|
major | 1 |
minor | 30 |
patch | 0 |
dev | true |