mobile: Fix the flaky SendDataTest Kotlin test #33230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test failed when adding the native Assertion filter, with an error from loadFromYaml: INVALID_ARGUMENT: could not find @type 'type.googleapis.com/envoymobile.extensions.filters.http.assertion.Assertion After running git bisect, it turns out the bad commit came from envoyproxy#33169. That PR introduces HttpTestServer to the SendDataTest.kt, which causes the required proto types to not get loaded. In this commit, the test is fixed by using a TestRemoteResponse filter, similar to the other Kotlin tests (e.g. SendTrailersTest). However, we need to figure out why the config filter protos aren't loading when creating the HttpTestServer. Signed-off-by: Ali Beyad <abeyad@google.com>
abeyad
requested review from
RyanTheOptimist,
alyssawilk and
fredyw
as code owners
Signed-off-by: Ali Beyad <abeyad@google.com>
abeyad
changed the title
|
/assign @fredyw |
|
/assign @RyanTheOptimist |
RyanTheOptimist
approved these changes
Apr 1, 2024
fredyw
added a commit
that referenced
this pull request
Apr 2, 2024
This PR fixes the JNI test server BUILD files by not depending on //library/jni:envoy_jni_lib but making it depend on //@envoy/test/test_common:test_version_linkstamp that can generate the build_scm_revision and build_scm_status constants. This PR also fixes the issue raised in #33230 but the fix in #33230 to use TestRemoteResponse is more correct and also more consistent with the other tests, so this PR simply removes the TODO instead of reverting the PR. I tested this by reverting the PR and running ./bazelw test --cache_test_results=no --test_output=streamed --config=mobile-test-android //test/kotlin/integration:send_data_test with and without this fix. Although, I still can't fully figure out why this PR fixes the issue, I suspect it is because it no longer depends on //library/jni:envoy_jni_lib, which indirectly depends on //library/cc:engine_builder_lib. Risk Level: low Testing: CI Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Fredy Wijaya <fredyw@google.com>
alyssawilk
pushed a commit
to alyssawilk/envoy
that referenced
this pull request
Apr 29, 2024
The test failed when adding the native Assertion filter, with an error from loadFromYaml: INVALID_ARGUMENT: could not find @type 'type.googleapis.com/envoymobile.extensions.filters.http.assertion.Assertion After running git bisect, it turns out the bad commit came from envoyproxy#33169. That PR introduces HttpTestServer to the SendDataTest.kt, which causes the required proto types to not get loaded. In this commit, the test is fixed by using a TestRemoteResponse filter, similar to the other Kotlin tests (e.g. SendTrailersTest). However, we need to figure out why the config filter protos aren't loading when creating the HttpTestServer. Signed-off-by: Ali Beyad <abeyad@google.com>
alyssawilk
pushed a commit
to alyssawilk/envoy
that referenced
this pull request
Apr 29, 2024
This PR fixes the JNI test server BUILD files by not depending on //library/jni:envoy_jni_lib but making it depend on //@envoy/test/test_common:test_version_linkstamp that can generate the build_scm_revision and build_scm_status constants. This PR also fixes the issue raised in envoyproxy#33230 but the fix in envoyproxy#33230 to use TestRemoteResponse is more correct and also more consistent with the other tests, so this PR simply removes the TODO instead of reverting the PR. I tested this by reverting the PR and running ./bazelw test --cache_test_results=no --test_output=streamed --config=mobile-test-android //test/kotlin/integration:send_data_test with and without this fix. Although, I still can't fully figure out why this PR fixes the issue, I suspect it is because it no longer depends on //library/jni:envoy_jni_lib, which indirectly depends on //library/cc:engine_builder_lib. Risk Level: low Testing: CI Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Fredy Wijaya <fredyw@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test failed when adding the native Assertion filter, with an error from loadFromYaml:
The failure was reproduced locally with:
After running git bisect, it turns out the bad commit came from #33169. That PR introduces HttpTestServer to the SendDataTest.kt, which causes the required proto types to not get loaded.
In this commit, the test is fixed by using a TestRemoteResponse filter, similar to the other Kotlin tests (e.g. SendTrailersTest). However, we need to figure out why the config filter protos aren't loading when creating the HttpTestServer.