Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mobile: Fix the flaky SendDataTest Kotlin test #33230

Merged
merged 2 commits into from
Apr 1, 2024
Merged

mobile: Fix the flaky SendDataTest Kotlin test #33230

merged 2 commits into from
Apr 1, 2024

Commits on Mar 30, 2024

  1. mobile: Fix the flaky SendDataTest 

    The test failed when adding the native Assertion filter, with an error
from loadFromYaml: INVALID_ARGUMENT: could not find @type
'type.googleapis.com/envoymobile.extensions.filters.http.assertion.Assertion

After running git bisect, it turns out the bad commit came from
envoyproxy#33169. That PR introduces
HttpTestServer to the SendDataTest.kt, which causes the required proto
types to not get loaded.

In this commit, the test is fixed by using a TestRemoteResponse filter,
similar to the other Kotlin tests (e.g. SendTrailersTest). However, we
need to figure out why the config filter protos aren't loading when
creating the HttpTestServer.

Signed-off-by: Ali Beyad <abeyad@google.com>
    @abeyad
    abeyad committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    7763cfb View commit details
    Browse the repository at this point in the history

  2. fix format 

    Signed-off-by: Ali Beyad <abeyad@google.com>
    @abeyad
    abeyad committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    32ffff8 View commit details
    Browse the repository at this point in the history