Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynamic_modules: exclude abi.h from clang-tidy #37317

Merged
merged 3 commits into from
Nov 25, 2024
Merged

dynamic_modules: exclude abi.h from clang-tidy #37317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21db5f2
dynamic_modules: exclude ABI C header from '-modernize-use-using'
mathetake Nov 22, 2024
f5f1311
Exclude the header in the first place
mathetake Nov 25, 2024
0bce9f1
ok
mathetake Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,9 @@ UseColor: true

WarningsAsErrors: '*'

# The ABI header file is a pure C header file, and clang-tidy is only for C++.
ExcludeHeaderFilterRegex: 'source/extensions/dynamic_modules/abi.h'

## The version here is arbitrary since any change to this file will
## trigger a full run of clang-tidy against all files.
## It can be useful as it seems some header changes may not trigger the
Expand Down
9 changes: 3 additions & 6 deletions source/extensions/dynamic_modules/abi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ extern "C" {
*
* OWNERSHIP: Envoy owns the pointer.
*/
typedef const char* // NOLINT(modernize-use-using)
envoy_dynamic_module_type_abi_version_envoy_ptr;
typedef const char* envoy_dynamic_module_type_abi_version_envoy_ptr;

/**
* envoy_dynamic_module_type_http_filter_config_envoy_ptr is a raw pointer to
Expand All @@ -47,8 +46,7 @@ typedef const char* // NOLINT(modernize-use-using)
*
* OWNERSHIP: Envoy owns the pointer.
*/
typedef const void* // NOLINT(modernize-use-using)
envoy_dynamic_module_type_http_filter_config_envoy_ptr;
typedef const void* envoy_dynamic_module_type_http_filter_config_envoy_ptr;

/**
* envoy_dynamic_module_type_http_filter_config_module_ptr is a pointer to an in-module HTTP
Expand All @@ -60,8 +58,7 @@ typedef const void* // NOLINT(modernize-use-using)
* OWNERSHIP: The module is responsible for managing the lifetime of the pointer. The pointer can be
* released when envoy_dynamic_module_on_http_filter_config_destroy is called for the same pointer.
*/
typedef const void* // NOLINT(modernize-use-using)
envoy_dynamic_module_type_http_filter_config_module_ptr;
typedef const void* envoy_dynamic_module_type_http_filter_config_module_ptr;

// -----------------------------------------------------------------------------
// ------------------------------- Event Hooks ---------------------------------
Expand Down
2 changes: 1 addition & 1 deletion source/extensions/dynamic_modules/abi_version.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ namespace DynamicModules {
#endif
// This is the ABI version calculated as a sha256 hash of the ABI header files. When the ABI
// changes, this value must change, and the correctness of this value is checked by the test.
const char* kAbiVersion = "164a60ff214ca3cd62526ddb7c3fe21cf943e8721a115c87feca81a58510072c";
const char* kAbiVersion = "152372902a15b54edce8a868b15931579b79d979dbc004689761b47b8622d4a3";

#ifdef __cplusplus
} // namespace DynamicModules
Expand Down