dynamic_modules: exclude abi.h from clang-tidy #37317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake
changed the title
|
cc @phlax |
|
Note: I wanted to use |
|
so as discussed in #37320 clang-tidy is currently disabled in the CI, so the change here is not checked there... At least it's working locally ;) |
phlax
reviewed
Nov 24, 2024
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake
changed the title
|
@phlax i went ahead and simply put the header in the ignore target of clang-tidy - see the description of the PR for detail! |
phlax
pushed a commit
that referenced
this pull request
Nov 26, 2024
…#37378) This directive was introduced in #37317 but turns out this is not available in LLVM 14. So for now we remove this. By the time we enable clang-tidy on CI we should find a way to ignore it, but for now simply remove it so that we can run clang-tidy locally. part of #28566 Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: dynamic_modules: dynamic_modules: exclude abi.h from clang-tidy
Additional Description:
This commit disables clang-tidy for the whole ABI header which is a pure C file.
Previously, I added
// NOLINTcomment line on each place,clang-tidy is only for C++ source code, so this disables it considering the
readability. This shouldn't be a problem as the header only has types and
function declarations.
Risk Level: none
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]