Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy: removes ExcludeHeaderFilterRegex not available in LLVM 14 #37378

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

mathetake
Copy link
Member

@mathetake mathetake commented Nov 26, 2024

This directive was introduced in #37317 but turns out this is not available in LLVM 14.
So for now we remove this. By the time we enable clang-tidy on CI we should find
a way to ignore it, but for now simply remove it so that we can run clang-tidy locally.

part of #28566

cc @phlax

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #37378 was opened by mathetake.

see: more, trace.

@mathetake mathetake marked this pull request as ready for review November 26, 2024 19:20
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @mathetake

@phlax phlax merged commit 0a40f40 into envoyproxy:main Nov 26, 2024
24 checks passed
@mathetake mathetake deleted the removesunsupported branch November 26, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants