New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeepAlive support #1031

Closed

arkodg opened this issue Feb 10, 2023 · 8 comments · Fixed by #2581

Assignees

Labels

area/api area/policy area/translator kind/enhancement road-to-ga stale

Milestone

Contributor

arkodg commented Feb 10, 2023

Description:
As a user I would like to enable and configure tcp keep-alive for 2 cases

downstream with client
upstream with server

here is the config needed in Envoy

How other Envoy based implementations express this as an API

Emissary has support https://www.getambassador.io/docs/emissary/latest/topics/using/keepalive#keepalive (unsure if this is downstream or upstream socket)
Istio supports Upstream Keepalive https://istio.io/v1.1/docs/reference/config/networking/v1alpha3/destination-rule/#ConnectionPoolSettings-TCPSettings-TcpKeepalive
Contour : TODO

arkodg added the kind/enhancement label

Contributor Author

arkodg commented Feb 10, 2023 •

edited

Loading

@youngnick do you think this is something that we will need to drive in EG first as an extension or do you think there are enough implementations out there that this can be directly defined in the Gateway API ?

github-actions bot commented Mar 13, 2023

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

github-actions bot added the stale label

alvin-7 commented Mar 17, 2023

I need this, when I use HTTPRoute, the connection is close, but I need keep-alive

github-actions bot removed the stale label

Contributor Author

arkodg commented Mar 17, 2023

similar to #1169 (comment)

github-actions bot commented Apr 16, 2023

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

github-actions bot added the stale label

arkodg mentioned this issue

proposal: TrafficPolicy #1492

Closed

arkodg removed the stale label

arkodg added this to the 0.6.0-rc1 milestone

github-actions bot commented Sep 11, 2023

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

github-actions bot added the stale label

arkodg mentioned this issue

proposal: ClientTrafficPolicy #1846

Closed

qicz removed the stale label

arkodg mentioned this issue

proposal: BackendTrafficPolicy #1821

Closed

arkodg self-assigned this

arkodg added area/api area/translator area/policy labels

arkodg added a commit to arkodg/gateway that referenced this issue


          api: TcpKeepAlive (downstream) in ClientTrafficPolicy

f1252cd

Relates to envoyproxy#1031

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

arkodg mentioned this issue

api: TcpKeepalive (downstream) in ClientTrafficPolicy #1925

Merged

arkodg added a commit to arkodg/gateway that referenced this issue


          api: TcpKeepAlive (downstream) in ClientTrafficPolicy

f442e25

Relates to envoyproxy#1031

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

arkodg added a commit that referenced this issue


          api: TcpKeepalive (downstream) in ClientTrafficPolicy (#1925)

2ba50ea

* api: TcpKeepAlive (downstream) in ClientTrafficPolicy

Relates to #1031

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* lint

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

arkodg added a commit to arkodg/gateway that referenced this issue


          Implement Downstream TcpKeepalive

8b0339e

Relates to envoyproxy#1031

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

arkodg mentioned this issue

Implement Downstream TcpKeepalive #1939

Merged

arkodg added a commit to arkodg/gateway that referenced this issue


          Implement Downstream TcpKeepalive

58dc653

Relates to envoyproxy#1031

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

arkodg added a commit that referenced this issue


          Implement Downstream TcpKeepalive (#1939)

7e77522

* Implement Downstream TcpKeepalive

Relates to #1031

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* rename files

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* default comments

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* comments

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* rebase and fix test case

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

arkodg removed this from the 0.6.0-rc1 milestone

arkodg added this to the Backlog milestone

arkodg mentioned this issue

api: tcpKeepAlive in BackendTrafficPolicy #2194

Merged

github-actions bot commented Nov 17, 2023

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

github-actions bot added the stale label

arkodg removed the stale label

Xunzhuo added the road-to-ga label

github-project-automation bot added this to Envoy Gateway: The Road to GA

Xunzhuo modified the milestones: Backlog, v1.0.0-rc1

github-project-automation bot moved this to Todo in Envoy Gateway: The Road to GA

Xunzhuo moved this from Todo to Done in Envoy Gateway: The Road to GA

Xunzhuo closed this as completed

arkodg reopened this

Xunzhuo moved this from Done to In Progress in Envoy Gateway: The Road to GA

github-actions bot commented Jan 18, 2024

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

github-actions bot added the stale label

guydc mentioned this issue

feat(translator): Implement BTP TCPKeepAlive #2581

Merged

arkodg closed this as completed in #2581

github-project-automation bot moved this from In Progress to Done in Envoy Gateway: The Road to GA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment