Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(translator): Implement BTP TCPKeepAlive #2581

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Conversation

guydc
Copy link
Contributor

@guydc guydc commented Feb 9, 2024

What this PR does / why we need it:
Implements upstream TCP keep alive API in BakcendTrafficPolicy.

Which issue(s) this PR fixes:
Fixes #1031

@guydc guydc requested a review from a team as a code owner February 9, 2024 14:25
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (bb59484) 64.06% compared to head (050328a) 64.09%.

Files Patch % Lines
internal/gatewayapi/backendtrafficpolicy.go 77.77% 6 Missing and 2 partials ⚠️
internal/ir/zz_generated.deepcopy.go 0.00% 4 Missing and 1 partial ⚠️
internal/xds/translator/cluster.go 85.71% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2581      +/-   ##
==========================================
+ Coverage   64.06%   64.09%   +0.03%     
==========================================
  Files         119      119              
  Lines       18640    18703      +63     
==========================================
+ Hits        11941    11988      +47     
- Misses       5915     5927      +12     
- Partials      784      788       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

arkodg
arkodg previously approved these changes Feb 9, 2024
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team February 9, 2024 18:53
Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Guy Daich <guy.daich@sap.com>
@guydc
Copy link
Contributor Author

guydc commented Feb 12, 2024

/retest

1 similar comment
@guydc
Copy link
Contributor Author

guydc commented Feb 12, 2024

/retest

@arkodg arkodg merged commit 2c1b946 into envoyproxy:main Feb 12, 2024
17 checks passed
arkodg added a commit to arkodg/gateway that referenced this pull request Feb 13, 2024
Between envoyproxy#2585
&
envoyproxy#2581

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg mentioned this pull request Feb 13, 2024
arkodg added a commit that referenced this pull request Feb 13, 2024
Between #2585
&
#2581

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
yaelSchechter pushed a commit to yaelSchechter/envoy-gateway that referenced this pull request Feb 14, 2024
Between envoyproxy#2585
&
envoyproxy#2581

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>
vixns pushed a commit to vixns/gateway that referenced this pull request Feb 18, 2024
Implement BTP TCPKeepAlive

Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Stéphane Cottin <stephane.cottin@vixns.com>
vixns pushed a commit to vixns/gateway that referenced this pull request Feb 18, 2024
Between envoyproxy#2585
&
envoyproxy#2581

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Stéphane Cottin <stephane.cottin@vixns.com>
zirain added a commit that referenced this pull request Feb 18, 2024
* feat: Suppress 'X-Envoy' headers and pass-through the upstream 'Server' header by default (#2585)

* Implement and update tests for the default header transformations.

Signed-off-by: Lior Okman <lior.okman@sap.com>

* Make 'gen-check' happy

Signed-off-by: Lior Okman <lior.okman@sap.com>

---------

Signed-off-by: Lior Okman <lior.okman@sap.com>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* bug: fix merge race (#2604)

Between #2585
&
#2581

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* feat: downstream mTLS (#2490)

* feat: downstream mTLS

Relates to #2483

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* configmap provider logic

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* gatewayapi translation

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix charts

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* tests

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* lint

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* add timeout to clientTrafficPolicy

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* fix comment

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* add omitempty

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* add cel test for coverage

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* run make commands

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* change request timeout field name and desc

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* tidy up comment

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* fix cel test

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* fix typo

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* run generate

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

---------

Signed-off-by: Lior Okman <lior.okman@sap.com>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Co-authored-by: Lior Okman <lior.okman@sap.com>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Co-authored-by: zirain <zirain2009@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeepAlive support
3 participants