-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(translator): Implement BTP TCPKeepAlive #2581
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2581 +/- ##
==========================================
+ Coverage 64.06% 64.09% +0.03%
==========================================
Files 119 119
Lines 18640 18703 +63
==========================================
+ Hits 11941 11988 +47
- Misses 5915 5927 +12
- Partials 784 788 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Guy Daich <guy.daich@sap.com>
/retest |
1 similar comment
/retest |
Between envoyproxy#2585 & envoyproxy#2581 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Between envoyproxy#2585 & envoyproxy#2581 Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: Yael Shechter <yael.shechter@sap.com>
Implement BTP TCPKeepAlive Signed-off-by: Guy Daich <guy.daich@sap.com> Signed-off-by: Stéphane Cottin <stephane.cottin@vixns.com>
Between envoyproxy#2585 & envoyproxy#2581 Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: Stéphane Cottin <stephane.cottin@vixns.com>
* feat: Suppress 'X-Envoy' headers and pass-through the upstream 'Server' header by default (#2585) * Implement and update tests for the default header transformations. Signed-off-by: Lior Okman <lior.okman@sap.com> * Make 'gen-check' happy Signed-off-by: Lior Okman <lior.okman@sap.com> --------- Signed-off-by: Lior Okman <lior.okman@sap.com> Signed-off-by: Yael Shechter <yael.shechter@sap.com> * bug: fix merge race (#2604) Between #2585 & #2581 Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: Yael Shechter <yael.shechter@sap.com> * feat: downstream mTLS (#2490) * feat: downstream mTLS Relates to #2483 Signed-off-by: Arko Dasgupta <arko@tetrate.io> * configmap provider logic Signed-off-by: Arko Dasgupta <arko@tetrate.io> * gatewayapi translation Signed-off-by: Arko Dasgupta <arko@tetrate.io> * fix charts Signed-off-by: Arko Dasgupta <arko@tetrate.io> * tests Signed-off-by: Arko Dasgupta <arko@tetrate.io> * lint Signed-off-by: Arko Dasgupta <arko@tetrate.io> --------- Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: Yael Shechter <yael.shechter@sap.com> * add timeout to clientTrafficPolicy Signed-off-by: Yael Shechter <yael.shechter@sap.com> * fix comment Signed-off-by: Yael Shechter <yael.shechter@sap.com> * add omitempty Signed-off-by: Yael Shechter <yael.shechter@sap.com> * add cel test for coverage Signed-off-by: Yael Shechter <yael.shechter@sap.com> * run make commands Signed-off-by: Yael Shechter <yael.shechter@sap.com> * change request timeout field name and desc Signed-off-by: Yael Shechter <yael.shechter@sap.com> * tidy up comment Signed-off-by: Yael Shechter <yael.shechter@sap.com> * fix cel test Signed-off-by: Yael Shechter <yael.shechter@sap.com> * fix typo Signed-off-by: Yael Shechter <yael.shechter@sap.com> * run generate Signed-off-by: Yael Shechter <yael.shechter@sap.com> --------- Signed-off-by: Lior Okman <lior.okman@sap.com> Signed-off-by: Yael Shechter <yael.shechter@sap.com> Signed-off-by: Arko Dasgupta <arko@tetrate.io> Co-authored-by: Lior Okman <lior.okman@sap.com> Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Co-authored-by: zirain <zirain2009@gmail.com>
What this PR does / why we need it:
Implements upstream TCP keep alive API in BakcendTrafficPolicy.
Which issue(s) this PR fixes:
Fixes #1031