Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Gateway API conformance in CI #157

Closed
skriss opened this issue Jul 15, 2022 · 3 comments
Closed

Run Gateway API conformance in CI #157

skriss opened this issue Jul 15, 2022 · 3 comments
Assignees
@skriss
Labels
area/ci CI and build related issues
Milestone
0.2.0

Comments

@skriss
Copy link
Contributor

skriss commented Jul 15, 2022

Gateway API conformance tests should run as part of CI, to serve as our end-to-end testing. We should run the set of tests that are included in the Gateway API release that we're using (currently v0.5.0). Initially we'll want these to be non-blocking as we work towards a conformant implementation, but eventually they should be merge-blocking.

xref. #65
@skriss skriss added the area/ci CI and build related issues label Jul 15, 2022
@skriss skriss added this to the 0.2.0-rc1 milestone Jul 15, 2022
@skriss skriss self-assigned this Jul 15, 2022
@skriss
Copy link
Contributor Author

skriss commented Aug 2, 2022

I've got much of this ready, but blocked for now until we have a functioning binary & YAML manifest.

skriss added a commit to skriss/gateway that referenced this issue Aug 24, 2022
@skriss
Add make targets for running Gateway API conformance
9c45df4 
Supports running Gateway API conformance in a kind
cluster against the envoyproxy/gateway-dev:latest
image.

Updates envoyproxy#157.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss mentioned this issue Aug 24, 2022
Merged
arkodg pushed a commit that referenced this issue Aug 24, 2022
@skriss
Add make targets for running Gateway API conformance (#195)
f2155be 
* Add make targets for running Gateway API conformance

Supports running Gateway API conformance in a kind
cluster against the envoyproxy/gateway-dev:latest
image.

Updates #157.

Signed-off-by: Steve Kriss <krisss@vmware.com>

* review comments

Signed-off-by: Steve Kriss <krisss@vmware.com>

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss
Copy link
Contributor Author

skriss commented Aug 24, 2022

Still to do:

  • add CI steps that run conformance
  • when running for a PR, use the container image built for the PR rather than the default envoyproxy/gateway-dev:latest

@danehans danehans modified the milestones: 0.2.0-rc1, 0.2.0 Aug 30, 2022
@Xunzhuo Xunzhuo mentioned this issue Sep 1, 2022
Closed
@arkodg
Copy link
Contributor

arkodg commented Sep 29, 2022

fixed with #425

@arkodg arkodg closed this as completed Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skriss skriss

Labels
area/ci CI and build related issues
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
3 participants
@danehans @skriss @arkodg