Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make targets for running Gateway API conformance #195

Merged
merged 2 commits into from
Aug 24, 2022

Conversation

skriss
Copy link
Contributor

@skriss skriss commented Aug 5, 2022

Supports running Gateway API conformance in a kind
cluster against the envoyproxy/gateway-dev:latest
image.

Updates #157.

Signed-off-by: Steve Kriss krisss@vmware.com

@skriss skriss force-pushed the pr-conformance-tests branch from a0b7ae4 to 2fb4b32 Compare August 5, 2022 19:26
@codecov-commenter
Copy link

Codecov Report

Merging #195 (2fb4b32) into main (f757292) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #195   +/-   ##
=======================================
  Coverage   59.80%   59.80%           
=======================================
  Files          24       24           
  Lines        2065     2065           
=======================================
  Hits         1235     1235           
  Misses        758      758           
  Partials       72       72           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@youngnick youngnick added this to the 0.2.0-rc1 milestone Aug 16, 2022
hack/run-conformance.sh Outdated Show resolved Hide resolved
@danehans
Copy link
Contributor

On /hold until #197 is merged.

@arkodg
Copy link
Contributor

arkodg commented Aug 18, 2022

thanks for proactively raising this @skriss
the content looks good, it would be great if the steps can be integrated into the existing kube targets https://github.com/envoyproxy/gateway/blob/main/tools/make/kube.mk because there is a lot of overlap there

Supports running Gateway API conformance in a kind
cluster against the envoyproxy/gateway-dev:latest
image.

Updates envoyproxy#157.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss force-pushed the pr-conformance-tests branch from 2fb4b32 to 9c45df4 Compare August 24, 2022 18:37
@skriss skriss changed the title WIP run Gateway API conformance Add make targets for running Gateway API conformance Aug 24, 2022
@skriss skriss marked this pull request as ready for review August 24, 2022 18:39
@skriss skriss requested a review from a team as a code owner August 24, 2022 18:39
@skriss
Copy link
Contributor Author

skriss commented Aug 24, 2022

This is ready for another review. Note that this PR only supports running conformance manually, against an already-built image. Will need another PR to add to CI and run against the image built for each PR.

tools/make/kube.mk Outdated Show resolved Hide resolved
Signed-off-by: Steve Kriss <krisss@vmware.com>
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

@arkodg arkodg merged commit f2155be into envoyproxy:main Aug 24, 2022
@skriss skriss deleted the pr-conformance-tests branch August 24, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants