chore: Bump k8s.io #3281
Merged
chore: Bump k8s.io #3281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps the k8s-io group with 6 updates: | Package | From | To | | --- | --- | --- | | [k8s.io/api](https://github.com/kubernetes/api) | `0.29.3` | `0.30.0` | | [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.29.3` | `0.30.0` | | [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.29.3` | `0.30.0` | | [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) | `0.29.3` | `0.30.0` | | [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.29.3` | `0.30.0` | | [k8s.io/kubectl](https://github.com/kubernetes/kubectl) | `0.29.3` | `0.30.0` | Updates `k8s.io/api` from 0.29.3 to 0.30.0 - [Commits](kubernetes/api@v0.29.3...v0.30.0) Updates `k8s.io/apiextensions-apiserver` from 0.29.3 to 0.30.0 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](kubernetes/apiextensions-apiserver@v0.29.3...v0.30.0) Updates `k8s.io/apimachinery` from 0.29.3 to 0.30.0 - [Commits](kubernetes/apimachinery@v0.29.3...v0.30.0) Updates `k8s.io/cli-runtime` from 0.29.3 to 0.30.0 - [Commits](kubernetes/cli-runtime@v0.29.3...v0.30.0) Updates `k8s.io/client-go` from 0.29.3 to 0.30.0 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.29.3...v0.30.0) Updates `k8s.io/kubectl` from 0.29.3 to 0.30.0 - [Commits](kubernetes/kubectl@v0.29.3...v0.30.0) --- updated-dependencies: - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-io - dependency-name: k8s.io/apiextensions-apiserver dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-io - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-io - dependency-name: k8s.io/cli-runtime dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-io - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-io - dependency-name: k8s.io/kubectl dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-io ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: zirain <zirain2009@gmail.com>
zirain
commented
Apr 26, 2024
| return err | ||
| } | ||
|
|
||
| // Only enqueue EnvoyProxy objects that match this Envoy Gateway's GatewayClass. | ||
| epPredicates := []predicate.Predicate{ | ||
| predicate.GenerationChangedPredicate{}, | ||
| predicate.ResourceVersionChangedPredicate{}, |
There was a problem hiding this comment.
@arkodg is this a must?
There was a problem hiding this comment.
can you track the orig commit for ResourceVersionChangedPredicate ? did the type get removed ?
There was a problem hiding this comment.
I can find a typed Predicate about that, actually I didn't understand why EG need it only for this.
This was referenced Apr 29, 2024
zhaohuabing
approved these changes
Apr 30, 2024
guydc
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #3237