Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade test should use v1.1.2 by default #4343

Closed
wants to merge 3 commits into from

Conversation

guydc
Copy link
Contributor

@guydc guydc commented Sep 26, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Guy Daich <guy.daich@sap.com>
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.97%. Comparing base (7babca9) to head (a3cd138).
Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4343      +/-   ##
==========================================
+ Coverage   65.95%   65.97%   +0.01%     
==========================================
  Files         197      197              
  Lines       23960    23960              
==========================================
+ Hits        15804    15808       +4     
+ Misses       7028     7026       -2     
+ Partials     1128     1126       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guydc
Copy link
Contributor Author

guydc commented Sep 26, 2024

probably blocked by the same problem as #4336

@zirain
Copy link
Contributor

zirain commented Oct 5, 2024

#4384 will fix this.

@guydc
Copy link
Contributor Author

guydc commented Oct 8, 2024

Closing in favor of #4393

@guydc guydc closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants