bump gwapi to 1.2.0 #4384
Merged
bump gwapi to 1.2.0 #4384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zirain <zirain2009@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4384 +/- ##
==========================================
+ Coverage 65.70% 65.73% +0.02%
==========================================
Files 200 200
Lines 24128 24141 +13
==========================================
+ Hits 15854 15868 +14
+ Misses 7139 7138 -1
Partials 1135 1135 ☔ View full report in Codecov by Sentry. |
|
looks like another CRD upgrade issue |
|
yeah, grpcroutes v1alpha2 was removed from gwapis 1.2.0. essentially, should not be there at all |
|
wait #4393 |
|
now, this one become clear to review. |
shawnh2
previously approved these changes
Oct 9, 2024
zhaohuabing
previously approved these changes
Oct 10, 2024
arkodg
reviewed
Oct 10, 2024
Xunzhuo
approved these changes
Oct 10, 2024
arkodg
approved these changes
Oct 10, 2024
juwon8891
pushed a commit
to juwon8891/gateway
that referenced
this pull request
Oct 22, 2024
* bump gwapi to 1.2.0 Signed-off-by: zirain <zirain2009@gmail.com> * use v1.1.2 Signed-off-by: zirain <zirain2009@gmail.com> * update Signed-off-by: zirain <zirain2009@gmail.com> * fix Signed-off-by: zirain <zirain2009@gmail.com> * lint Signed-off-by: zirain <zirain2009@gmail.com> * update Signed-off-by: zirain <zirain2009@gmail.com> * remove Signed-off-by: zirain <zirain2009@gmail.com> --------- Signed-off-by: zirain <zirain2009@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.