Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove backendrefs validation #4705

Merged
merged 5 commits into from
Nov 14, 2024

Conversation

zhaohuabing
Copy link
Member

@zhaohuabing zhaohuabing commented Nov 11, 2024

Fixes #4704

Remove backendrefs validation from the ExtAuth API for backward compatiblity.

Release Notes: Yes

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing marked this pull request as ready for review November 11, 2024 18:19
@arkodg
Copy link
Contributor

arkodg commented Nov 11, 2024

hey @zhaohuabing thanks for picking this up, can we add a test in gateway-api to make sure the backendRef field translation actually works ?

cc @zirain

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 80.55556% with 7 lines in your changes missing coverage. Please review.

Project coverage is 65.58%. Comparing base (c2b0ee3) to head (c42636a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/securitypolicy.go 80.55% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4705      +/-   ##
==========================================
+ Coverage   65.55%   65.58%   +0.03%     
==========================================
  Files         211      211              
  Lines       31972    31995      +23     
==========================================
+ Hits        20960    20985      +25     
+ Misses       9768     9767       -1     
+ Partials     1244     1243       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaohuabing zhaohuabing marked this pull request as draft November 11, 2024 18:30
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing marked this pull request as ready for review November 11, 2024 19:48
@arkodg arkodg requested review from a team November 14, 2024 15:10
@zirain zirain merged commit 5068698 into envoyproxy:main Nov 14, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Direct Response Route incorrectly being configured
3 participants