xds: always use `::` and `IPv4Compact` for dynamic listener #4743

zirain · 2024-11-20T04:45:25Z

this's a huge changes seperated from #4690.
we still need a PR to fix the bootstrap, especially for admin endpoint.

zirain · 2024-11-20T04:46:21Z

internal/gatewayapi/listener.go

@@ -99,6 +100,10 @@ func (t *Translator) ProcessListeners(gateways []*GatewayContext, xdsIR resource
 			if !isReady {
 				continue
 			}
+
+			// EG always use `::` and set ipv4_compact with true to support both IPv4 and IPv6


here is the key changes

Should we also use :: and ipv4_compact for IPv4 only environment? What if IPv6 is not supported by the underlying OS?

@zirain Could you please help me understand:

why prefer :: and ipv4_compact over addtional address?

would this approbach work with IPv4 only or underlying OS doesn't support IPv6?

for my poor understanding, this's just like net.Listen("tcp", ":8000") in golang, or maybe I'm wrong.

codecov · 2024-11-20T04:52:27Z

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.60%. Comparing base (2def6a4) to head (12ad43f).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/cmd/envoy/shutdown_manager.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4743      +/-   ##
==========================================
- Coverage   65.62%   65.60%   -0.03%     
==========================================
  Files         211      211              
  Lines       31984    31961      -23     
==========================================
- Hits        20990    20968      -22     
+ Misses       9755     9753       -2     
- Partials     1239     1240       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests

zhaohuabing · 2024-11-20T07:36:39Z

@zirain let's hold this after v1.2.2 because it changes too many files and would make cherry-picking harder.

internal/gatewayapi/translator.go

arkodg · 2024-11-20T18:00:57Z

@zirain let's hold this after v1.2.2 because it changes too many files and would make cherry-picking harder.

@zhaohuabing imo this should of v1.2 since its part of the dual stack feature

Signed-off-by: zirain <zirain2009@gmail.com>

arkodg

LGTM thanks !

zhaohuabing · 2024-11-21T01:54:34Z

@zirain let's hold this after v1.2.2 because it changes too many files and would make cherry-picking harder.

@zhaohuabing imo this should of v1.2 since its part of the dual stack feature

OK, let's cherry-pick this to v1.2.2

zhaohuabing · 2024-11-21T07:48:14Z

LGTM thanks!

One non-blocking comment: Envoy now listens on all IP Families by default including IPv4 and IPv6, regardless of the IPFamily setting. It might be usefult to clarify this behavior in the IPFamily API docs to avoid potential confusion.

zirain · 2024-11-21T08:13:02Z

LGTM thanks!

One non-blocking comment: Envoy now listens on all IP Families by default including IPv4 and IPv6, regardless of the IPFamily setting. It might be usefult to clarify this behavior in the IPFamily API docs to avoid potential confusion.

Will update these once we make an agreement on admin endpoint.

…xy#4743) * enable IPv4Compact Signed-off-by: zirain <zirain2009@gmail.com> * fix xds test Signed-off-by: zirain <zirain2009@gmail.com> * release-notes Signed-off-by: zirain <zirain2009@gmail.com> * nit Signed-off-by: zirain <zirain2009@gmail.com> * gen Signed-off-by: zirain <zirain2009@gmail.com> --------- Signed-off-by: zirain <zirain2009@gmail.com> (cherry picked from commit 78da42c) Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* fix: tcp listener is rejected when no route attached (#4681) * fix: tcp listener is rejected when no route attached Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * change cluter name Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * fix listener connection limit test Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * fix listener connetcp keepalive test Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * fix tcp endpoint stats test Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * fix tcp-route-enable-req-resp-sizes-stats Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * fix extensionpolicy-tcp-udp-http test Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * fix lint Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> --------- Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> (cherry picked from commit f99c36c) Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * fix: remove backendrefs validation (#4705) * remove backendrefs validation Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * add tests Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * add tests Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> --------- Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> Co-authored-by: zirain <zirain2009@gmail.com> (cherry picked from commit 5068698) Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * fix: translator reports errors for existing clusters and secretes (#4707) * fix: existing clusters and secretes Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * fix cluster index for SP Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * minor change Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * minor change Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * minor change Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * minor change Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * fix lint Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * add comment Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * remove index Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * fix lint Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> --------- Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * xds: always use `::` and `IPv4Compact` for dynamic listener (#4743) * enable IPv4Compact Signed-off-by: zirain <zirain2009@gmail.com> * fix xds test Signed-off-by: zirain <zirain2009@gmail.com> * release-notes Signed-off-by: zirain <zirain2009@gmail.com> * nit Signed-off-by: zirain <zirain2009@gmail.com> * gen Signed-off-by: zirain <zirain2009@gmail.com> --------- Signed-off-by: zirain <zirain2009@gmail.com> (cherry picked from commit 78da42c) Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * Fix: frequent 503 errors when connecting to a Service experiencing high Pod churn (#4754) * Revert "fix: some status updates are discarded by the status updater (#4337)" This reverts commit 14830c7. Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * store update events and process it later Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * rename method Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * add release note Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> --------- Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * xds: use V4_PREFERRED dnsLookupFamily by default (#4745) * use Cluster_V4_PREFERRED Signed-off-by: zirain <zirain2009@gmail.com> * release notes Signed-off-by: zirain <zirain2009@gmail.com> --------- Signed-off-by: zirain <zirain2009@gmail.com> --------- Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> Signed-off-by: zirain <zirain2009@gmail.com> Co-authored-by: zirain <zirain2009@gmail.com>

zirain requested a review from a team as a code owner November 20, 2024 04:45

zirain commented Nov 20, 2024

View reviewed changes

arkodg reviewed Nov 20, 2024

View reviewed changes

internal/gatewayapi/translator.go Outdated Show resolved Hide resolved

zirain added 4 commits November 21, 2024 02:52

enable IPv4Compact

1897c91

Signed-off-by: zirain <zirain2009@gmail.com>

fix xds test

546df43

Signed-off-by: zirain <zirain2009@gmail.com>

release-notes

7c8d70e

Signed-off-by: zirain <zirain2009@gmail.com>

nit

ee4568a

Signed-off-by: zirain <zirain2009@gmail.com>

zirain force-pushed the ipv6-dynamic-listener branch from d1f4f7d to ee4568a Compare November 20, 2024 18:54

gen

4efd0c7

Signed-off-by: zirain <zirain2009@gmail.com>

arkodg approved these changes Nov 20, 2024

View reviewed changes

arkodg requested review from a team and zhaohuabing November 20, 2024 19:28

zhaohuabing added the cherrypick/release-v1.2.2 label Nov 21, 2024

zhaohuabing approved these changes Nov 21, 2024

View reviewed changes

Merge branch 'main' into ipv6-dynamic-listener

12ad43f

zirain merged commit 78da42c into envoyproxy:main Nov 21, 2024
24 checks passed

zirain deleted the ipv6-dynamic-listener branch November 21, 2024 09:08

zhaohuabing mentioned this pull request Nov 22, 2024

[release/v1.2] cherry pick bug fixes and IPv6 to v1.2.2 #4765

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

xds: always use `::` and `IPv4Compact` for dynamic listener #4743

xds: always use `::` and `IPv4Compact` for dynamic listener #4743

zirain commented Nov 20, 2024 •

edited

Loading

zirain Nov 20, 2024

zhaohuabing Nov 20, 2024 •

edited

Loading

zhaohuabing Nov 21, 2024 •

edited

Loading

zirain Nov 21, 2024

codecov bot commented Nov 20, 2024 •

edited

Loading

zhaohuabing commented Nov 20, 2024 •

edited

Loading

arkodg commented Nov 20, 2024

arkodg left a comment

zhaohuabing commented Nov 21, 2024

zhaohuabing commented Nov 21, 2024 •

edited

Loading

zirain commented Nov 21, 2024

xds: always use :: and IPv4Compact for dynamic listener #4743

xds: always use :: and IPv4Compact for dynamic listener #4743

Conversation

zirain commented Nov 20, 2024 • edited Loading

zirain Nov 20, 2024

Choose a reason for hiding this comment

zhaohuabing Nov 20, 2024 • edited Loading

Choose a reason for hiding this comment

zhaohuabing Nov 21, 2024 • edited Loading

Choose a reason for hiding this comment

zirain Nov 21, 2024

Choose a reason for hiding this comment

codecov bot commented Nov 20, 2024 • edited Loading

Codecov Report

zhaohuabing commented Nov 20, 2024 • edited Loading

arkodg commented Nov 20, 2024

arkodg left a comment

Choose a reason for hiding this comment

zhaohuabing commented Nov 21, 2024

zhaohuabing commented Nov 21, 2024 • edited Loading

zirain commented Nov 21, 2024

xds: always use `::` and `IPv4Compact` for dynamic listener #4743

xds: always use `::` and `IPv4Compact` for dynamic listener #4743

zirain commented Nov 20, 2024 •

edited

Loading

zhaohuabing Nov 20, 2024 •

edited

Loading

zhaohuabing Nov 21, 2024 •

edited

Loading

codecov bot commented Nov 20, 2024 •

edited

Loading

zhaohuabing commented Nov 20, 2024 •

edited

Loading

zhaohuabing commented Nov 21, 2024 •

edited

Loading