-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sotw code cleanup #438
Closed
Closed
sotw code cleanup #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alec Holmes <alecholmez@me.com>
Signed-off-by: Alec Holmes <alecholmez@me.com>
Signed-off-by: Alec Holmes <alecholmez@me.com>
There is a slight perf concern (additional goroutines per stream) with making this change, I wonder if we want to wait until we have mem/speed benchmarks until we make a change like this to SotW since it's in active use? |
@snowp I'm not opposed to that. go routines are relatively lightweight but I think it's a good idea to measure the current performance first. |
…5bbb Signed-off-by: go-control-plane(Azure Pipelines) <go-control-plane@users.noreply.github.com>
…a1bf Signed-off-by: go-control-plane(Azure Pipelines) <go-control-plane@users.noreply.github.com>
…ab39 Signed-off-by: go-control-plane(Azure Pipelines) <go-control-plane@users.noreply.github.com>
…d0e3 Signed-off-by: go-control-plane(Azure Pipelines) <go-control-plane@users.noreply.github.com>
…0bf8 Signed-off-by: go-control-plane(Azure Pipelines) <go-control-plane@users.noreply.github.com>
Signed-off-by: Alec Holmes <alecholmez@me.com>
…b199 Signed-off-by: go-control-plane(Azure Pipelines) <go-control-plane@users.noreply.github.com>
fixed integration tests for ads
…fe31 Signed-off-by: go-control-plane(Azure Pipelines) <go-control-plane@users.noreply.github.com>
…ab58 Signed-off-by: go-control-plane(Azure Pipelines) <go-control-plane@users.noreply.github.com>
…dbc1 Signed-off-by: go-control-plane(Azure Pipelines) <go-control-plane@users.noreply.github.com>
…e43f Signed-off-by: go-control-plane(Azure Pipelines) <go-control-plane@users.noreply.github.com>
…0f7e Signed-off-by: go-control-plane(Azure Pipelines) <go-control-plane@users.noreply.github.com>
…1410 Signed-off-by: go-control-plane(Azure Pipelines) <go-control-plane@users.noreply.github.com>
Signed-off-by: Pavel Forkert <fxposter@gmail.com>
…7b08 Signed-off-by: go-control-plane(Azure Pipelines) <go-control-plane@users.noreply.github.com>
…73bc Signed-off-by: go-control-plane(Azure Pipelines) <go-control-plane@users.noreply.github.com>
…0083 Signed-off-by: go-control-plane(Azure Pipelines) <go-control-plane@users.noreply.github.com>
…215d Signed-off-by: go-control-plane(Azure Pipelines) <go-control-plane@users.noreply.github.com>
…d40e Signed-off-by: go-control-plane(Azure Pipelines) <go-control-plane@users.noreply.github.com>
…bf6f Signed-off-by: go-control-plane(Azure Pipelines) <go-control-plane@users.noreply.github.com>
…73e5 Signed-off-by: go-control-plane(Azure Pipelines) <go-control-plane@users.noreply.github.com>
…5067 Signed-off-by: go-control-plane(Azure Pipelines) <go-control-plane@users.noreply.github.com>
…c613 Signed-off-by: go-control-plane(Azure Pipelines) <go-control-plane@users.noreply.github.com>
…4666 Signed-off-by: go-control-plane(Azure Pipelines) <go-control-plane@users.noreply.github.com>
…1216 Signed-off-by: go-control-plane(Azure Pipelines) <go-control-plane@users.noreply.github.com>
…362b Signed-off-by: go-control-plane(Azure Pipelines) <go-control-plane@users.noreply.github.com>
…b554 Signed-off-by: go-control-plane(Azure Pipelines) <go-control-plane@users.noreply.github.com>
…7466 Signed-off-by: go-control-plane(Azure Pipelines) <go-control-plane@users.noreply.github.com>
…d623 Signed-off-by: go-control-plane(Azure Pipelines) <go-control-plane@users.noreply.github.com>
Signed-off-by: Alec Holmes <alecholmez@me.com>
Signed-off-by: Alec Holmes <alecholmez@me.com>
Signed-off-by: Alec Holmes <alecholmez@me.com>
Signed-off-by: Alec Holmes <alecholmez@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert