-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server api without linearization #443
Conversation
Signed-off-by: Pavel Forkert <fxposter@gmail.com>
This will conflict with #438 |
For those who does not want to dig deep into all previous issues: this changes the API between cache and server packages to allow to maintain the order of responses of different types from the cache side. |
I was pretty busy last 2 months, but previously it was tested and just needed to rebase to merge: #376 (comment). Since there were many changes since then - maybe we should do another round of tests, but from code perspective - nothing significant has changed since previous PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, I won't stand in the way since this was already good to merge previously.
No worries on the conflict we aren't sure if we want to go that route (waiting on some benchmarks first) so I can just address that when I need to.
I'll probably open a PR that follows this for Incremental soon, it would be helpful if you could put your eyes on that when it's opened to make sure I don't miss anything.
Signed-off-by: Pavel Forkert <fxposter@gmail.com>
Signed-off-by: Pavel Forkert <fxposter@gmail.com>
Signed-off-by: Pavel Forkert <fxposter@gmail.com>
This is the rebased version of #376.
@kyessenov @jessicayuen @snowp @alecholmez