Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dedupe code between PerformNighthawkBenchmark and RemoteProcessImpl::run #496

Closed
oschaaf opened this issue Aug 28, 2020 · 0 comments · Fixed by #548
Closed

Dedupe code between PerformNighthawkBenchmark and RemoteProcessImpl::run #496

oschaaf opened this issue Aug 28, 2020 · 0 comments · Fixed by #548
Assignees
@oschaaf
Labels
tech-debt

Comments

@oschaaf
Copy link
Member

oschaaf commented Aug 28, 2020

These two methods are pretty similar in terms of implementation, but they take slightly different arguments.
It should be possible to unify them.

Related discussion: #493 (comment)
@oschaaf oschaaf mentioned this issue Aug 28, 2020
Merged
oschaaf added a commit to oschaaf/nighthawk that referenced this issue Sep 22, 2020
@oschaaf
Implement RemoteProcessImpl in terms of PerformNighthawkBenchmark()
f263b52 
Drop duplicated code, use the newer code that has better test
coverage plus handling for when multiple results would be received.

Fixes envoyproxy#496

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf oschaaf mentioned this issue Sep 22, 2020
Merged
@oschaaf oschaaf self-assigned this Sep 22, 2020
mum4k pushed a commit that referenced this issue Sep 22, 2020
@oschaaf
Implement RemoteProcessImpl in terms of PerformNighthawkBenchmark() (#…
8ed1f68 
…548)

Drop duplicated code, use the newer code that has better test
coverage plus handling for when multiple results would be received.

Fixes #496

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oschaaf oschaaf

Labels
tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement RemoteProcessImpl in terms of PerformNighthawkBenchmark() oschaaf/nighthawk
1 participant
@oschaaf