Moving our Python tools from on-host Python to Hermetic Python. #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated the bazel WORKSPACE to use hermetic Python. - bazel-ified `format_python_tools` and `flake8` executions. - migrated our Python requirements management to using a lockfile. Not updating the requirements in this PR to keep it small, will do in a follow-up. - removing the pin on the `envoyproxy/envoy-build-ubuntu`, we are once again using the same version as Envoy. - disabling our `clang-tidy` CI check. It doesn't work with the new Docker image and hermetic Python. Envoy is working on a new solution upstream which we will adopt once available. - passing the correct directory to the `check_format` and `format_python_tools` script, so that it actually checks our files for formatting. This was a pre-existing issue which resulted in multiple format violations. Making the format check information-only at this PR. Will fix formatting of all files in a follow-up. Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
phlax
reviewed
Oct 26, 2023
fei-deng
reviewed
Oct 26, 2023
fei-deng
approved these changes
Oct 26, 2023
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
|
@phlax PTAL |
phlax
approved these changes
Oct 26, 2023
mum4k
added a commit
to mum4k/nighthawk
that referenced
this pull request
Oct 26, 2023
Not used since envoyproxy#1033. Signed-off-by: Jakub Sobon <mumak@google.com>
mum4k
added a commit
that referenced
this pull request
Oct 27, 2023
Not used since #1033. Signed-off-by: Jakub Sobon <mumak@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WORKSPACEto use hermetic Python.format_python_toolsandflake8executions.the requirements in this PR to keep it small, will do in a follow-up. Just merging all
the requirements and still using
==pins in this PR.envoyproxy/envoy-build-ubuntu, we are once againusing the same version as Envoy.
clang-tidyCI check. It doesn't work with the new Dockerimage and hermetic Python. Envoy is working on a new solution upstream which
we will adopt once available.
check_formatandformat_python_toolsscript, so that it actually checks our files for formatting. This was a
pre-existing issue which resulted in multiple format violations. Making the
format check information-only at this PR. Will fix formatting of all files in
a follow-up.
will be updated once more in a follow-up PR once I remove pins (
==) fromrequirements.in.Works on #1032