Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving our Python tools from on-host Python to Hermetic Python. #1033

Merged
merged 9 commits into from
Oct 26, 2023
Merged

Moving our Python tools from on-host Python to Hermetic Python. #1033

merged 9 commits into from
Oct 26, 2023

Commits on Oct 25, 2023

  1. Moving our Python tools from on-host Python to Hermetic Python. 

    - updated the bazel WORKSPACE to use hermetic Python.
- bazel-ified `format_python_tools` and `flake8` executions.
- migrated our Python requirements management to using a lockfile. Not updating
  the requirements in this PR to keep it small, will do in a follow-up.
- removing the pin on the `envoyproxy/envoy-build-ubuntu`, we are once again
  using the same version as Envoy.
- disabling our `clang-tidy` CI check. It doesn't work with the new Docker
  image and hermetic Python. Envoy is working on a new solution upstream which
  we will adopt once available.
- passing the correct directory to the `check_format` and `format_python_tools`
  script, so that it actually checks our files for formatting. This was a
  pre-existing issue which resulted in multiple format violations. Making the
  format check information-only at this PR. Will fix formatting of all files in
  a follow-up.

Signed-off-by: Jakub Sobon <mumak@google.com>
    @mum4k
    mum4k committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    0c92a36 View commit details
    Browse the repository at this point in the history

  2. Update instructions on how to perform a Python dep update. 

    Signed-off-by: Jakub Sobon <mumak@google.com>
    @mum4k
    mum4k committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    71ab9f1 View commit details
    Browse the repository at this point in the history

  3. Updating the instructions - self-review. 

    Signed-off-by: Jakub Sobon <mumak@google.com>
    @mum4k
    mum4k committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    daa911a View commit details
    Browse the repository at this point in the history

  4. Remove commented-out code. 

    Signed-off-by: Jakub Sobon <mumak@google.com>
    @mum4k
    mum4k committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    168b831 View commit details
    Browse the repository at this point in the history

  5. Update docstrings in format_python_tools.py. 

    Signed-off-by: Jakub Sobon <mumak@google.com>
    @mum4k
    mum4k committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    bdcb8e2 View commit details
    Browse the repository at this point in the history

  6. Update spacing in docstrings. 

    Signed-off-by: Jakub Sobon <mumak@google.com>
    @mum4k
    mum4k committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    6ff70c7 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. FIxing typos in docs/root/updating_envoy_dependency.md. 

    Signed-off-by: Jakub Sobon <mumak@google.com>
    @mum4k
    mum4k committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    f02a90a View commit details
    Browse the repository at this point in the history

  2. Remove pip-compile options we don't need. 

    Signed-off-by: Jakub Sobon <mumak@google.com>
    @mum4k
    mum4k committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    9a7a196 View commit details
    Browse the repository at this point in the history

  3. Renaming s/python_pip_deps/nh_pip3. 

    Signed-off-by: Jakub Sobon <mumak@google.com>
    @mum4k
    mum4k committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    6349726 View commit details
    Browse the repository at this point in the history