Skip to content

Commit

Permalink
[enzyme] [fix] lock cheerio to rc 3
Browse files Browse the repository at this point in the history 
See cheeriojs/cheerio#1585
  • Loading branch information
@ljharb
ljharb committed Dec 22, 2020
1 parent 6e990c0 commit cafdb2b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/enzyme/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"license": "MIT",
"dependencies": {
"array.prototype.flat": "^1.2.3",
"cheerio": "^1.0.0-rc.3",
"cheerio": "=1.0.0-rc.3",
"enzyme-shallow-equal": "^1.0.4",
"function.prototype.name": "^1.1.2",
"has": "^1.0.3",
Expand Down

8 comments on commit cafdb2b

@jsg2021
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been released? I'm still seeing "cheerio": "^1.0.0-rc.3", in the enzyme package.json in my node_modules on 3.11.0? or is npm 8 converting = to ^ ?

@ljharb
Copy link
Member Author

@ljharb ljharb commented on cafdb2b May 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this hasn't been released.

@jsg2021
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kk, I found this because over the last week cheerio added an exports map, and attempts to require into the module's undeclared files now fail... I worked around it locally by pinning cheerio to rc3 in my project's package.json

@Alevale
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ljharb could we cherry pick this by any chance? It would fix #2607 AFAIK

Out of curiosity, why wasn't this picked into the package?

@ljharb
Copy link
Member Author

@ljharb ljharb commented on cafdb2b Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alevale it's already on main, there's no need to cherry-pick anything. It's just that enzyme hasn't yet had a release since before this commit landed.

@raphaelboukara
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to release a patch to get this one?

@raphaelboukara
Copy link

@raphaelboukara raphaelboukara commented on cafdb2b Aug 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Alevale 🙏
Do you have an ETA about his one? How many time it takes in general to release?
It's pretty urgent for us, we have an organisation with a lot of packages and we are actually in a situation where we are adding:

"overrides": {
    "cheerio": "1.0.0-rc.3"
}

to all our package.json 😔. Because of the stable release of cheerio to 1.0.0 that happened last week.

@Alevale
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raphaelboukara unfortunately/fortunately I am not an owner nor maintainer for any of those packages, I'm just another affected user 😢

Please sign in to comment.