Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cheerio in Enzyme 3.11.0 isn't pinned to the right version #2607

Closed
Alevale opened this issue Aug 12, 2024 · 1 comment
Closed

Cheerio in Enzyme 3.11.0 isn't pinned to the right version #2607

Alevale opened this issue Aug 12, 2024 · 1 comment

Comments

@Alevale
Copy link

Alevale commented Aug 12, 2024

Current behavior

When using the version of enzyme 3.11.0 we are using under the hood cheerio

Cheerio is evolving and as of their 1.0.0version (released 3 days ago) they don't expose the lib folder anymore in their new version.

This means we have to pin the dependency to "cheerio": "=1.0.0-rc.3", in the latest enzyme package like it is in master.

This is breaking the package with the following message

Module not found: Error: Package path ./lib/utils is not exported from package /builds/some-app/node_modules/cheerio (see exports field in /some-app/node_modules/cheerio/package.json)

Expected behavior

When I use enzime I don't have to create overrides for external libraries in my own project

Your environment

Does not apply

Related issues

cheeriojs/cheerio#4001

@ljharb
Copy link
Member

ljharb commented Aug 13, 2024

Duplicate of #2558, already fixed in the next release.

@ljharb ljharb closed this as not planned Won't fix, can't repro, duplicate, stale Aug 13, 2024
glepretre added a commit to Kozea/formol that referenced this issue Sep 3, 2024
cheerio (https://github.com/cheeriojs/cheerio) has release an official 1.0.0
version after years of Release Candidate ones.

cheeriojs/cheerio#4044
cheeriojs/cheerio#4032
cheeriojs/cheerio#3987

We depend on enzyme (https://github.com/enzymejs/enzyme) which depends
on cheerio.

Enzyme has not correctly locked cheerio RC version:
enzymejs/enzyme@cafdb2b

They're working on it...
enzymejs/enzyme#2558
enzymejs/enzyme#2606
enzymejs/enzyme#2607
enzymejs/enzyme#2608
enzymejs/enzyme#2609

Meanwhile, locking cheerio here allow us to update our dependencies.

According to enzyme, Cheerio RC was the last one supported by enzyme,
even though RC12 seems to work for us.
glepretre added a commit to Kozea/formol that referenced this issue Sep 3, 2024
cheerio (https://github.com/cheeriojs/cheerio) has released an official 1.0.0
version after years of Release Candidate ones.

cheeriojs/cheerio#4044
cheeriojs/cheerio#4032
cheeriojs/cheerio#3987

We depend on enzyme (https://github.com/enzymejs/enzyme) which depends
on cheerio.

Enzyme has not correctly locked cheerio RC version:
enzymejs/enzyme@cafdb2b

They're working on it...
enzymejs/enzyme#2558
enzymejs/enzyme#2606
enzymejs/enzyme#2607
enzymejs/enzyme#2608
enzymejs/enzyme#2609

Meanwhile, locking cheerio here allow us to update our dependencies.

According to enzyme, Cheerio RC was the last one supported by enzyme,
even though RC12 seems to work for us.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants