Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RXN2000/3000 should not serialize INDIGO_DESC fields for s-groups #1056

Closed
KonstantinEpam23 opened this issue Mar 7, 2023 · 1 comment · Fixed by #1059
Closed

RXN2000/3000 should not serialize INDIGO_DESC fields for s-groups #1056

KonstantinEpam23 opened this issue Mar 7, 2023 · 1 comment · Fixed by #1059
Assignees
@even1024
Labels
Bug
Milestone
Indigo-1.11.0-rc.1

Comments

@KonstantinEpam23
Copy link

Steps to Reproduce

  1. Convert the following .ket file to rxn format via Indigo: ket-reaction-arrow.ket.zip
  2. Observe the resulting rxn file

Expected behavior
INDIGO_xxx_DESC fields are not serialized

Actual behavior
INDIGO_xxx_DESC fields appear in the output

Attachments
Screenshot 2023-03-07 at 14 51 10

Indigo/Bingo version
1.10-rc.4
@AlexanderSavelyev AlexanderSavelyev added this to the Indigo-1.11.0-rc.1 milestone Mar 7, 2023
@KonstantinEpam23 KonstantinEpam23 mentioned this issue Mar 7, 2023
Closed
@KonstantinEpam23
Copy link
Author

Related issue: #1031

@even1024 even1024 linked a pull request Mar 9, 2023 that will close this issue
#1056 RXN2000/3000 should not serialize INDIGO_DESC fields for s-groups #1059
Merged
AlexanderSavelyev pushed a commit that referenced this issue Mar 13, 2023
@even1024
#1056 RXN2000/3000 should not serialize INDIGO_DESC fields for s-grou…
eca69b5 
…ps (#1059)

* indigo desc

* desc fix

* desc fix

* desc fix

* desc fix

* desc fix

* desc fix

---------

Co-authored-by: Roman Porozhnetov <roman_porozhnetov@epam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@even1024 even1024

Labels
Bug
Projects
None yet
Milestone
Indigo-1.11.0-rc.1
Development

Successfully merging a pull request may close this issue.

#1056 RXN2000/3000 should not serialize INDIGO_DESC fields for s-groups epam/Indigo
3 participants
@AlexanderSavelyev @even1024 @KonstantinEpam23