Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RXN v2000: Detection molecule above/below arrow as reagent doesn't work #2062

Closed
Zhirnoff opened this issue Jan 6, 2023 · 2 comments · Fixed by #2307
Closed

RXN v2000: Detection molecule above/below arrow as reagent doesn't work #2062

Zhirnoff opened this issue Jan 6, 2023 · 2 comments · Fixed by #2307
Assignees
@Konstantin1996 @Nitvex
Labels
bug
Milestone
Ketcher 2.10.0-rc.1

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jan 6, 2023 •
edited
Loading

Preconditions

  1. Ketcher is launched.
  2. Structures added to canvas ketcher (57).zip

Steps to Reproduce

  1. Click on saving icon or uses a shortcut Ctr+S
  2. Choose 'MDL rxnfile V2000' format from the 'File format' dropdown
  3. Check "Preview" tab

Expected behavior
System detect molecule as reagent and write reagent in 'MDL rxnfile V2000' format in "Preview" tab
2023-01-06_12h54_33

Actual behavior
Detection molecule above/below arrow as reagent doesn't work.

Attachments
2023-01-06_12h54_26

Indigo/Bingo version
Indigo Toolkit
Version 1.9.0-rc.2.0-g40c4e3793-x86_64-linux-gnu-11.2.1
@Zhirnoff Zhirnoff added the bug label Jan 6, 2023
@Zhirnoff Zhirnoff added this to the Release Candidate 2.8.0-rc.1 milestone Jan 6, 2023
@Nitvex
Copy link
Collaborator

Nitvex commented Jan 6, 2023

This issue will be fixed by moving RXN formatting to Indigo side. At the moment, RXN, Ket and Molv2000 are parsed on Ketcher side, but we are planning to move RXN to Indigo.
In order to do that it is required to change formatterFactory.ts and its create method.

@Konstantin1996 Konstantin1996 self-assigned this Mar 2, 2023
@KonstantinEpam23
Copy link
Collaborator

Related indigo issue: epam/Indigo#1056

@Konstantin1996 Konstantin1996 linked a pull request Mar 8, 2023 that will close this issue
#2062 RXN v2000: Detection molecule above/below arrow as reagent doesn't work #2307
Merged
Nitvex pushed a commit that referenced this issue Mar 22, 2023
@Konstantin1996
#2062 RXN v2000: Detection molecule above/below arrow as reagent does…
3d864fd 
…n't work (#2307)

* - moved SupportedFormat.rxn to ServerFormatter

* - removed RxnFormatter

---------

Co-authored-by: Konstantin Zharich <kostantin_zharich@epam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Konstantin1996 Konstantin1996

@Nitvex Nitvex

Labels
bug
Projects
None yet
Milestone
Ketcher 2.10.0-rc.1
Development

Successfully merging a pull request may close this issue.

#2062 RXN v2000: Detection molecule above/below arrow as reagent doesn't work epam/ketcher
4 participants
@Konstantin1996 @Nitvex @Zhirnoff @KonstantinEpam23