Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support of unsplit nucleotides #1919

Closed
olganaz opened this issue Apr 18, 2024 · 3 comments · Fixed by #2007
Closed

Support of unsplit nucleotides #1919

olganaz opened this issue Apr 18, 2024 · 3 comments · Fixed by #2007
Assignees
@AliaksandrDziarkach
Labels
epic: macromolecules IDT Test Cases Written Test cases has been written for that issue
Milestone
Indigo-1.22.0-rc.1

Comments

@olganaz
Copy link
Collaborator

olganaz commented Apr 18, 2024 •
edited by AlexeyGirin
Loading

Background
In some cases there is no need to divide modified nucleotides to submonomers (sugar, base, phosphate). Such nucleotides should be supported as single monomers.

Requirements

  1. Unsplit nucleotides are nucleotides which have chemical structure, but submonomers (sugar, base, phosphate) are not specified
  2. Unsplit nucleotides should have base natural analog
  3. Unsplit nucleotides should have "class": "Nucleotide"
@olganaz olganaz added this to the Indigo-1.22.0-rc.1 milestone Jun 6, 2024
@AlexeyGirin
Copy link
Collaborator

UI part is here: epam/ketcher#4382

@AlexeyGirin AlexeyGirin added the Test Cases Written Test cases has been written for that issue label Jun 13, 2024
@AlexeyGirin
Copy link
Collaborator

No test cases needed for that tech task.
(it simply adds new class to ket - that would be verified manually once)

@AliaksandrDziarkach AliaksandrDziarkach self-assigned this Jun 14, 2024
AliaksandrDziarkach added a commit that referenced this issue Jun 17, 2024
@AliaksandrDziarkach
#1919 Support of unsplit nucleotides
290c701 
Update code add UTs
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Jun 17, 2024 that will close this issue
#1919 Support of unsplit nucleotides #2007
Merged
7 tasks
AliaksandrDziarkach added a commit that referenced this issue Jun 18, 2024
@AliaksandrDziarkach
#1919 Support of unsplit nucleotides (#2007)
ed3c615
@AlexeyGirin
Copy link
Collaborator

Verified.

  • Ketcher Version 2.22.0-rc.2 Build at 2024-06-28; 05:30:15
  • Indigo Toolkit Version 1.22.0-dev.2.1-gd5637f75-wasm32-wasm-clang-12.0.0
  • Windows 10 Pro
  • Chrome Version 126.0.6478.127 (Official Build) (64-bit)

@github-project-automation github-project-automation bot moved this to Done in Indigo Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliaksandrDziarkach AliaksandrDziarkach

Labels
epic: macromolecules IDT Test Cases Written Test cases has been written for that issue
Projects
Indigo
Status: Done
Milestone
Indigo-1.22.0-rc.1
Development

Successfully merging a pull request may close this issue.

#1919 Support of unsplit nucleotides epam/Indigo
3 participants
@AliaksandrDziarkach @AlexeyGirin @olganaz