Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro: Support of unsplit nucleotides #4382

Closed
olganaz opened this issue Apr 1, 2024 · 4 comments · Fixed by #4860
Closed

Macro: Support of unsplit nucleotides #4382

olganaz opened this issue Apr 1, 2024 · 4 comments · Fixed by #4860
Assignees
Labels
feature request IDT Bucket: IDT related issues Test Cases Written Test cases has been written for that issue

Comments

@olganaz
Copy link
Collaborator

olganaz commented Apr 1, 2024

Background
In some cases there is no need to divide modified nucleotides to submonomers (sugar, base, phosphate). Such nucleotides should be supported as single monomers.

Requirements

  1. Unsplit nucleotides are nucleotides which have chemical structure, but submonomers (sugar, base, phosphate) are not specified

  2. Additional chapter 'Nucleotides' should be introduced in a RNA tab of Ketcher library

  3. Unsplit nucleotides should have base natural analog

  4. Unsplit nucleotides should be grouped by natural analog in a library.
    - Nucleotides, for which a natural analogue is not specified, should be grouped in a separate section in a library ("No natural analogue")

  5. Unsplit nucleotides should not interrupt enumeration of RNA chain in flex mode

  6. Unsplit nucleotides should be displayed:

    • in flex/snake modes - as a pentagon with name (see mockups)
    • in sequence view - as natural analog symbol if it's specified, otherwise - as '@' symbol
  7. On preview chemical structure together with name and IDT alias should be displayed.

  8. Establishing connections between unsplit nucleotides should be performed as for peptide monomers (center-to-center, center-to-point , point-to-center, point-to-point).

Examples
Unsplit_nucleotides.zip
iAmMC6T.zip - has 4 AP

IDT name Full name Natural analog
/5Super-dG/ 5' Super G G
/55Br-dU/ 5' 5-Bromo dU U
/5Super-dT/ 5' Super T T
/55HydMe-dC/ 5' 5-Hydroxymethyl dC C
/55NitInd/ 5' 5-Nitroindole X
/5AmdA/ 5' 2, 6-Diaminopurine A
/iAmMC6T/ Int Amino Modifier C6 dT T

UX
image

@olganaz
Copy link
Collaborator Author

olganaz commented Jun 4, 2024

Attached files with examples suitable for testing

@olganaz olganaz added the IDT Bucket: IDT related issues label Jun 6, 2024
@svvald svvald self-assigned this Jun 6, 2024
@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Jun 7, 2024

Unsplit nucleotides is a new entity, it's like CHEMS, only different

Questions to @olganaz

  1. Where are nucleotides located if they do not have a natural analogue? (we sort them by it). - X group?
  2. How do you understand that a nucleotide does not have a natural analogue? - no grouping in the library
  3. Displaying Unsplit nucleotides as ordinary nucleotides in sequence mode is not very convenient - mixing two different entities - do we really want this?

@AlexeyGirin AlexeyGirin added the Questions remain If that issue has unresolved questions label Jun 7, 2024
@olganaz
Copy link
Collaborator Author

olganaz commented Jun 10, 2024

  1. Added the requirement
  2. separate group in library
  3. TBC

@AlexeyGirin AlexeyGirin added Test Cases Written Test cases has been written for that issue and removed Questions remain If that issue has unresolved questions labels Jun 13, 2024
@svvald svvald linked a pull request Jun 19, 2024 that will close this issue
9 tasks
svvald added a commit that referenced this issue Jun 24, 2024
svvald added a commit that referenced this issue Jun 24, 2024
svvald added a commit that referenced this issue Jun 25, 2024
svvald added a commit that referenced this issue Jun 25, 2024
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jul 2, 2024

Tested.
We have many bugs described above
Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.23.0-rc.1]
Indigo version
[Version 1.22.0-rc.1]

@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request IDT Bucket: IDT related issues Test Cases Written Test cases has been written for that issue
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants