Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert api does not recognise format during autodetection #1989

Closed
rrodionov91 opened this issue Jun 6, 2024 · 1 comment · Fixed by #2463
Closed

Convert api does not recognise format during autodetection #1989

rrodionov91 opened this issue Jun 6, 2024 · 1 comment · Fixed by #2463
Assignees
@AlexeyGirin
Labels
Priority: Medium
Milestone
Indigo-1.25.0-rc.1

Comments

@rrodionov91
Copy link
Collaborator

rrodionov91 commented Jun 6, 2024 •
edited
Loading

Steps to Reproduce

  1. Send IDT string (f.e. /52MOErA/*/i2MOErC/*/32MOErT/) to convert api without "input_format": "chemical/x-idt" parameter

Expected behavior
Indigo converts string in any macromolecules format supported on ketcher side(MolV3000, Sequence, Fasta, IDT, HELM) to KET format. In case if it is not possible to identify format (f.e. ACGT could be interpreted as IDT as well as Sequence or Fasta) - use the simplest one.

Actual behavior
Indigo returns error:
image

Environment details:

  • Back-end version - Indigo 1.21.0-rc.1
  • [Optional] Ketcher 2.22.0-rc.3
@rrodionov91 rrodionov91 added this to the Indigo-1.21.0-rc.2 milestone Jun 6, 2024
@rrodionov91 rrodionov91 added Bug and removed Bug labels Jun 6, 2024
@AlexeyGirin AlexeyGirin added Bug and removed Feature labels Jun 7, 2024
@rrodionov91 rrodionov91 mentioned this issue Jun 10, 2024
Closed
@Zhirnoff Zhirnoff mentioned this issue Jul 9, 2024
Open
@rrodionov91 rrodionov91 changed the title Convert api does not recognise IDT format during autodetection Convert api does not recognise format during autodetection Aug 9, 2024
@github-project-automation github-project-automation bot moved this to To Do in Indigo Aug 27, 2024
@AlexeyGirin AlexeyGirin removed this from the Indigo-1.24.0-rc.1 milestone Sep 4, 2024
@AlexeyGirin AlexeyGirin added this to the Indigo-1.25.0-rc.1 milestone Sep 4, 2024
AliaksandrDziarkach pushed a commit that referenced this issue Oct 1, 2024
#1989 - Convert api does not recognise format during autodetection
4d70a14 
Add code. Add UT
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Oct 1, 2024 that will close this issue
#1989 - Convert api does not recognise format during autodetection #2463
Merged
7 tasks
AlexanderSavelyev pushed a commit that referenced this issue Oct 2, 2024
@AliaksandrDziarkach
#1989 - Convert api does not recognise format during autodetection (#…
5782327 
…2463)

Co-authored-by: Aliakasndr Dziarkach <Aliakasndr.Dziarkach@gmail.com>
@github-project-automation github-project-automation bot moved this from To Do to Done in Indigo Oct 2, 2024
@AlexeyGirin
Copy link
Collaborator

Verified.

Versions

  • Ketcher Version 2.26.0-rc.1 Build at 2024-10-04; 18:45:04
  • Indigo Toolkit Version 1.25.0-rc.1.0-g704673fcb-wasm32-wasm-clang-19.0.0
  • Chrome Version 129.0.6668.90 (Official Build) (64-bit)
  • Win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyGirin AlexeyGirin

Labels
Priority: Medium
Projects
Indigo
Status: Done
Milestone
Indigo-1.25.0-rc.1
Development

Successfully merging a pull request may close this issue.

#1989 - Convert api does not recognise format during autodetection epam/Indigo
4 participants
@even1024 @rrodionov91 @AliaksandrDziarkach @AlexeyGirin