Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pasting IDT structures via clipboard does not work #4739

Closed
Zhirnoff opened this issue Jun 4, 2024 · 2 comments · Fixed by #4745 or #4746
Closed

Pasting IDT structures via clipboard does not work #4739

Zhirnoff opened this issue Jun 4, 2024 · 2 comments · Fixed by #4745 or #4746
Assignees
@rrodionov91
Labels
IDT Bucket: IDT related issues Macromolecules Priority: Medium
Milestone
Ketcher 2.22.0-rc.3

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jun 4, 2024

Steps to Reproduce

  1. Open Macro mode
  2. Copy to clipboard IDT /32MOErA/
  3. Paste to canvas

Actual behavior
Pasting IDT structures via clipboard does not work

Expected behavior
Structure pasted on canvas

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.22.0-rc.1]
@Zhirnoff Zhirnoff added this to the Ketcher 2.22.0-rc.3 milestone Jun 4, 2024
@rrodionov91 rrodionov91 self-assigned this Jun 4, 2024
rrodionov91 added a commit that referenced this issue Jun 4, 2024
@rrodionov91
#4739 - Pasting IDT structures via clipboard does not work
91a6bb6 
- removed error on ketcher side if format was not detected
@rrodionov91 rrodionov91 linked a pull request Jun 4, 2024 that will close this issue
#4739 - Pasting IDT structures via clipboard does not work #4745
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jun 4, 2024
@rrodionov91
#4739 - Pasting IDT structures via clipboard does not work
00c6511 
- removed error on ketcher side if format was not detected
@rrodionov91 rrodionov91 linked a pull request Jun 4, 2024 that will close this issue
Backmerge: #4739 - Pasting IDT structures via clipboard does not work #4746
Merged
9 tasks
@Zhirnoff Zhirnoff changed the title Pasting IDT structures via clipboard does not work Pasting IDT structures via clipboard does not work after switch micro/macro mode Jun 4, 2024
@Zhirnoff Zhirnoff changed the title Pasting IDT structures via clipboard does not work after switch micro/macro mode Pasting IDT structures via clipboard does not work Jun 4, 2024
rrodionov91 added a commit that referenced this issue Jun 6, 2024
@rrodionov91
#4739 - Pasting IDT structures via clipboard does not work (#4745)
98ca5cd 
- removed error on ketcher side if format was not detected
rrodionov91 added a commit that referenced this issue Jun 6, 2024
@rrodionov91
#4739 - Pasting IDT structures via clipboard does not work (#4746)
d86e93f 
- removed error on ketcher side if format was not detected
@rrodionov91
Copy link
Collaborator

Changed ketcher behaviour to send string from clipboard to indigo and rely on it's format autodetection algorithm in case if ketcher didn't recognize format.
Indigo ticket for IDT format autodetection epam/Indigo#1989

@Zhirnoff
Copy link
Collaborator Author

Tested. Changes were made only on the Ketcher side. A fix is ​​required on the Indigo side of the ticket epam/Indigo#1989
Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.22.0-rc.3]
Indigo version
[Version 1.21.0-rc.1]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
IDT Bucket: IDT related issues Macromolecules Priority: Medium
Projects
None yet
Milestone
Ketcher 2.22.0-rc.3
2 participants
@rrodionov91 @Zhirnoff