Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import of variant monomers from Sequence doesn't work for RNA and FASTA for RNA/DNA #2303

Closed
AlexeyGirin opened this issue Sep 4, 2024 · 1 comment · Fixed by #2391 or #2393
Closed

Import of variant monomers from Sequence doesn't work for RNA and FASTA for RNA/DNA #2303

AlexeyGirin opened this issue Sep 4, 2024 · 1 comment · Fixed by #2391 or #2393
Assignees
@AliaksandrDziarkach
Labels
Bug Priority: High Sequence mode Bucket: Sequence mode related issues
Milestone
Indigo-1.24.0-rc.3

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Sep 4, 2024 •
edited
Loading

Steps to Reproduce

  1. Toggle to Macro - Flex
  2. Load using paste from clipboard way RNA sequence (or FASTA): RYMKSWHBVDN
    image

Actual behavior
System throws exception: Convert error! Given string could not be loaded as (query or plain) molecule or reaction, see the error messages
image

Expected behavior
No exception. Loading works as intended
image

Versions

  • Ketcher Version 2.25.0-rc.1 Build at 2024-09-03; 15:31:03
  • Indigo Toolkit Version 1.24.0-rc.1.0-gb8f099851-wasm32-wasm-clang-19.0.0
  • Chrome Version 128.0.6613.114 (Official Build) (64-bit)
  • Win10

Reference issues: #2015
@AlexeyGirin AlexeyGirin added Bug Priority: High Sequence mode Bucket: Sequence mode related issues labels Sep 4, 2024
@AlexeyGirin AlexeyGirin added this to the Indigo-1.24.0-rc.2 milestone Sep 4, 2024
@AlexeyGirin AlexeyGirin changed the title Import of variant monomers from Sequence doesn't work for RNA Import of variant monomers from Sequence/FASTA doesn't work for RNA Sep 4, 2024
@AlexeyGirin AlexeyGirin changed the title Import of variant monomers from Sequence/FASTA doesn't work for RNA Import of variant monomers from Sequence doesn't work for RNA and FASTA for RNA/DNA Sep 9, 2024
AliaksandrDziarkach added a commit that referenced this issue Sep 16, 2024
@AliaksandrDziarkach
#2303 - Import of variant monomers from Sequence doesn't work for RN…
60af756 
…A and FASTA for RNA/DNA

Fix code. Update UT
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Sep 16, 2024 that will close this issue
#2303 - Import of variant monomers from Sequence doesn't work for RNA and FASTA for RNA/DNA #2391
Merged
8 tasks
AliaksandrDziarkach added a commit that referenced this issue Sep 16, 2024
@AliaksandrDziarkach
Backmerge: #2303 - Import of variant monomers from Sequence doesn't w…
07043f1 
…ork for RNA and FASTA for RNA/DNA

backmerge to master
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Sep 16, 2024 that will close this issue
Backmerge: #2303 - Import of variant monomers from Sequence doesn't work for RNA and FASTA for RNA/DNA #2393
Merged
4 tasks
@AliaksandrDziarkach AliaksandrDziarkach self-assigned this Sep 16, 2024
AlexanderSavelyev pushed a commit that referenced this issue Sep 17, 2024
@AliaksandrDziarkach
#2303 - Import of variant monomers from Sequence doesn't work for RN…
169ffcd 
…A and FASTA for RNA/DNA (#2391)
AlexanderSavelyev pushed a commit that referenced this issue Sep 17, 2024
@AliaksandrDziarkach
Backmerge: #2303 - Import of variant monomers from Sequence doesn't w…
956c763 
…ork for RNA and FASTA for RNA/DNA (#2393)
@Zhirnoff
Copy link
Collaborator

Tested. Bug fixed.
2024-09-19_12h22_12

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.25.0-rc.3]
Indigo version
[Version 1.24.0-rc.3]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliaksandrDziarkach AliaksandrDziarkach

Labels
Bug Priority: High Sequence mode Bucket: Sequence mode related issues
Projects
None yet
Milestone
Indigo-1.24.0-rc.3
3 participants
@AliaksandrDziarkach @AlexeyGirin @Zhirnoff