Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2404 - Save Name and Reaction Conditions to RDF Metadata #2640

Merged
merged 29 commits into from
Nov 25, 2024
Merged

#2404 - Save Name and Reaction Conditions to RDF Metadata #2640

merged 29 commits into from
Nov 25, 2024

Conversation

even1024
Copy link
Collaborator

Generic request

  • PR name follows the pattern #1234 – issue name
  • branch name does not contain '#'
  • base branch (master or release/xx) is correct
  • PR is linked with the issue
  • task status changed to "Code review"
  • code follows product standards
  • regression tests updated

This was linked to issues Nov 18, 2024
Save Name and Reaction Conditions to RDF Metadata #2404
Closed
Preview: When Reaction Conditions text field is empty, clicking on placeholder text on canvas results in a blank line, with no visible text #2608
Closed
@even1024 even1024 changed the title 2404 ket to rdf #2404 - Save Name and Reaction Conditions to RDF Metadata Nov 18, 2024
@even1024 even1024 linked an issue Nov 19, 2024 that may be closed by this pull request
Preview: Text above reaction arrow ignores margins when atoms are added #2610
Closed
This was linked to issues Nov 22, 2024
Preview: Reaction's name or conditions text wraps incorrectly: the line should only break after a complete word, ensuring no more than 30 characters per line #2646
Closed
Preview: Unexpected additional new lines are added to text object of reaction's name and conditions in case of several rows of text after save/load to/from RDF or Layout actions #2645
Closed
Preview: Reaction's name and conditions change places between parts of cascade reaction with Multi-Tailed and Single arrows after save/load to/from RDF or Layout actions #2643
Closed
Not correct length of Multi-Tailed and Single arrows for reactions with atoms after loading from RDF or Layout actions #2583
Closed
@even1024 even1024 linked an issue Nov 22, 2024 that may be closed by this pull request
Reaction's name or conditions text wraps incorrectly in specific cases: the last line before truncating, removing of special symbols, empty line instead of "..." #2647
Closed
@AlexanderSavelyev AlexanderSavelyev merged commit eb2f140 into master Nov 25, 2024
72 checks passed
@AlexanderSavelyev AlexanderSavelyev deleted the 2404-ket-to-rdf branch November 25, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSavelyev AlexanderSavelyev AlexanderSavelyev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preview: Reaction's name and conditions change places between parts of cascade reaction with Multi-Tailed and Single arrows after save/load to/from RDF or Layout actions Preview: Text above reaction arrow ignores margins when atoms are added Preview: When Reaction Conditions text field is empty, clicking on placeholder text on canvas results in a blank line, with no visible text Not correct length of Multi-Tailed and Single arrows for reactions with atoms after loading from RDF or Layout actions Save Name and Reaction Conditions to RDF Metadata
Preview: Unexpected additional new lines are added to text object of reaction's name and conditions in case of several rows of text after save/load to/from RDF or Layout actions Preview: Reaction's name or conditions text wraps incorrectly: the line should only break after a complete word, ensuring no more than 30 characters per line Reaction's name or conditions text wraps incorrectly in specific cases: the last line before truncating, removing of special symbols, empty line instead of "..."
2 participants
@even1024 @AlexanderSavelyev