Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2404 - Save Name and Reaction Conditions to RDF Metadata #2640

Open
wants to merge 28 commits into
base: master
Choose a base branch
from

Conversation

even1024
Copy link
Collaborator

Generic request

  • PR name follows the pattern #1234 – issue name
  • branch name does not contain '#'
  • base branch (master or release/xx) is correct
  • PR is linked with the issue
  • task status changed to "Code review"
  • code follows product standards
  • regression tests updated

@@ -341,13 +350,19 @@ void PathwayLayout::generateTextBlocks(SimpleTextObjectBuilder& tob, const ObjAr
{
for (int i = 0; i < props.size(); ++i)
{
if (height > _text_height)
if (std::round(height * 1000) >= std::round(_text_line_height * 1000))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add constant for 1000

SimpleTextLine textLine;
textLine.text = props[i].ptr();
if (height < _text_height && props.size() - i > 1)
textLine.text += "...";
if (std::round(height * 1000) < std::round(_text_line_height * 1000) && props.size() - i > 1)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add constant for 1000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment