#3495 fix dispatch selectTool rerender issue

epam · Nov 23, 2023 · 6b894d7 · 6b894d7
1 parent 698fe7e
commit 6b894d7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/packages/ketcher-polymer-editor-react/src/Editor.tsx b/packages/ketcher-polymer-editor-react/src/Editor.tsx
@@ -126,7 +126,6 @@ function Editor({ theme, togglerComponent }: EditorProps) {
   const canvasRef = useRef<SVGSVGElement>(null);
   const errorTooltipText = useAppSelector(selectErrorTooltipText);
   const editor = useAppSelector(selectEditor);
-  const activeTool = useAppSelector(selectEditorActiveTool);
   let keyboardEventListener;
   const [isMonomerLibraryHidden, setIsMonomerLibraryHidden] = useState(false);
 
@@ -194,10 +193,10 @@ function Editor({ theme, togglerComponent }: EditorProps) {
     debouncedShowPreview({ monomer, style: previewStyle });
   }, []);
 
-  const handleClosePreview = () => {
+  const handleClosePreview = useCallback(() => {
     debouncedShowPreview.cancel();
     dispatch(showPreview(undefined));
-  };
+  }, []);
 
   useEffect(() => {
     editor?.events.mouseOverMonomer.add((e) => {
@@ -210,7 +209,7 @@ function Editor({ theme, togglerComponent }: EditorProps) {
       handleClosePreview();
       handleOpenPreview(e);
     });
-  }, [editor, activeTool]);
+  }, [editor, handleOpenPreview, handleClosePreview]);
 
   useEffect(() => {
     editor?.zoomTool.observeCanvasResize();

diff --git a/...r-polymer-editor-react/src/components/monomerLibrary/monomerLibraryGroup/MonomerGroup.tsx b/...r-polymer-editor-react/src/components/monomerLibrary/monomerLibraryGroup/MonomerGroup.tsx
@@ -74,8 +74,7 @@ const MonomerGroup = ({
   };
 
   const selectMonomer = (monomer: MonomerItemType) => {
-    // why would this re-render rnabuilder?
-    // dispatch(selectTool('monomer'));
+    dispatch(selectTool('monomer'));
     setSelectedItemInGroup(monomer);
 
     if (['FAVORITES', 'PEPTIDE', 'CHEM'].includes(libraryName ?? '')) {