Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: Is not possible to add RNA presets into the Favourite library #3495

Closed
MartaWilliams opened this issue Oct 24, 2023 · 1 comment · Fixed by #3584
Closed

Macro: Is not possible to add RNA presets into the Favourite library #3495

MartaWilliams opened this issue Oct 24, 2023 · 1 comment · Fixed by #3584
Assignees
@StarlaStarla
Labels
bug Macromolecules Priority: Low
Milestone
Macromolecules Mi...

Comments

@MartaWilliams
Copy link
Collaborator

Steps to Reproduce

  • Go to Macromolecules mode
  • Click the RNA tab
  • Click on Presets
  • Hover over any of the RNA presets structure

Actual behaviour
There is no star on RNA presets structures allowing them to be add into Favorite library.

Expected behavior
Displaying a star for adding presets to favorites: A star for adding RNA presets to Favorite library shall appear in the upper left corner inside presets framework.

image
image

Task related: #3041
@Zhirnoff Zhirnoff changed the title Macro: Is not possible to add RNA presents into the Favourite library Macro: Is not possible to add RNA presets into the Favourite library Oct 25, 2023
@OlZhur OlZhur added this to the Macromolecules Milestone 2 milestone Oct 25, 2023
StarlaStarla added a commit that referenced this issue Nov 17, 2023
@StarlaStarla
#3495 add RNA presets into the Favourite library
81183d4
@StarlaStarla StarlaStarla linked a pull request Nov 17, 2023 that will close this issue
Macro: #3495 - Is not possible to add RNA presets into the Favourite library #3584
Merged
9 tasks
StarlaStarla added a commit that referenced this issue Nov 17, 2023
@StarlaStarla
#3495 fix ci error
5160d33
StarlaStarla added a commit that referenced this issue Nov 17, 2023
@StarlaStarla
#3495 update autotests
b52115d
StarlaStarla added a commit that referenced this issue Nov 17, 2023
@StarlaStarla
#3495 update tests
8b5e7ad
StarlaStarla added a commit that referenced this issue Nov 17, 2023
@StarlaStarla
#3495 update tests
7844d35
StarlaStarla added a commit that referenced this issue Nov 17, 2023
@StarlaStarla
#3495 fix test command
2d3357d
@StarlaStarla StarlaStarla linked a pull request Nov 17, 2023 that will close this issue
Macro: #3598- Fix CI test command and unit tests #3586
Merged
9 tasks
StarlaStarla added a commit that referenced this issue Nov 21, 2023
@StarlaStarla
#3495 fix unit tests
3a5bbc5
@StarlaStarla StarlaStarla removed a link to a pull request Nov 22, 2023
Macro: #3598- Fix CI test command and unit tests #3586
Merged
9 tasks
StarlaStarla added a commit that referenced this issue Nov 22, 2023
@StarlaStarla
#3495 fix input lost focus issue
0baf296
StarlaStarla added a commit that referenced this issue Nov 23, 2023
@StarlaStarla
#3495 fix input lost focus issue
711a640
StarlaStarla added a commit that referenced this issue Nov 23, 2023
@StarlaStarla
#3495 disable duplication for undefined preset
698fe7e
StarlaStarla added a commit that referenced this issue Nov 23, 2023
@StarlaStarla
#3495 fix dispatch selectTool rerender issue
6b894d7
StarlaStarla added a commit that referenced this issue Nov 23, 2023
@StarlaStarla
#3495 fix preset name auto fill issue
a6cd402
StarlaStarla added a commit that referenced this issue Nov 23, 2023
@StarlaStarla
#3495 fix screenshots
6f3672b
StarlaStarla added a commit that referenced this issue Nov 28, 2023
@StarlaStarla
#3495 fix ci issue
981e6be
StarlaStarla added a commit that referenced this issue Nov 28, 2023
@StarlaStarla
#3495 fix autotest issue and prevent rerender of RnaEditor
e617a6d
StarlaStarla added a commit that referenced this issue Nov 28, 2023
@StarlaStarla
#3495 fix ci issue
fa2f846
StarlaStarla added a commit that referenced this issue Nov 28, 2023
@StarlaStarla
#3495 fix unit tests
0c532fd
StarlaStarla added a commit that referenced this issue Nov 28, 2023
@StarlaStarla
#3495 update screenshots
2c2408b
StarlaStarla added a commit that referenced this issue Nov 30, 2023
@StarlaStarla
#3495 fix duplicate preset name issue
4612884
StarlaStarla added a commit that referenced this issue Nov 30, 2023
@StarlaStarla
#3495 fix duplicate preset name issue
4c139de
StarlaStarla added a commit that referenced this issue Nov 30, 2023
@StarlaStarla
#3495 fix duplicated preset name issue
9cb5cb7
StarlaStarla added a commit that referenced this issue Nov 30, 2023
@StarlaStarla
#3495 fix autotests
e924654
StarlaStarla added a commit that referenced this issue Nov 30, 2023
@StarlaStarla
#3495 update screenshot
d3efa7e
StarlaStarla added a commit that referenced this issue Dec 1, 2023
@StarlaStarla
#3495 merge choosing RNA parts
757a051
StarlaStarla added a commit that referenced this issue Dec 1, 2023
@StarlaStarla
#3495 refresh selected monomer after changed monomer group
79c0e95
StarlaStarla added a commit that referenced this issue Dec 1, 2023
@StarlaStarla
#3495 enable expanding monomer group not in edit mode
768f6ae
Nitvex pushed a commit that referenced this issue Dec 1, 2023
@StarlaStarla
Macro: #3495 - Is not possible to add RNA presets into the Favourite …
ceb5a86 
…library (#3584)

* #3495 add RNA presets into the Favourite library

* #3495 fix ci error

* #3495 update tests

* #3495 fix input lost focus issue

* #3495 disable duplication for undefined preset

* #3495 fix dispatch selectTool rerender issue

* #3495 fix preset name auto fill issue

* #3495 fix screenshots

* #3495 fix ci issue

* #3495 fix autotest issue and prevent rerender of RnaEditor

* #3495 fix ci issue

* #3495 fix unit tests

* #3495 update screenshots

* #3495 fix duplicate preset name issue

* #3495 fix duplicated preset name issue

* #3495 fix autotests

* #3495 update screenshot

* #3495 merge choosing RNA parts

* #3495 refresh selected monomer after changed monomer group

* #3495 enable expanding monomer group not in edit mode
@Zhirnoff
Copy link
Collaborator

Manual tests added to the table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StarlaStarla StarlaStarla

Labels
bug Macromolecules Priority: Low
Projects
Macromolecules Milestone 3
Status: Done
Milestone
Macromolecules Milestone 3
Development

Successfully merging a pull request may close this issue.

Macro: #3495 - Is not possible to add RNA presets into the Favourite library epam/ketcher
6 participants
@rrodionov91 @AlexeyGirin @StarlaStarla @Zhirnoff @MartaWilliams @OlZhur