Macro: #3495 - Is not possible to add RNA presets into the Favourite library #3584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StarlaStarla
force-pushed
the
3495-macro-is-not-possible-to-add-rna-presets-into-the-favourite-library
branch
from
b52115d to
8b5e7ad
Compare
StarlaStarla
force-pushed
the
3495-macro-is-not-possible-to-add-rna-presets-into-the-favourite-library
branch
from
8b5e7ad to
7844d35
Compare
StarlaStarla
requested review from
MartaWilliams
and removed request for
Zhirnoff
|
Tested: |
MartaWilliams
approved these changes
Nov 20, 2023
Nitvex
reviewed
Nov 21, 2023
| }); | ||
|
|
||
| test('Should have star when hover over RNA presets', async ({ page }) => { | ||
| await page.getByTestId('A_A_R_P').hover(); |
There was a problem hiding this comment.
My proposal is not to add a lot of screenshots. if tests can be written w/o it, let's do it.
So for this specific case – you can screenshot NOT whole page, but only specific DOM-element.
In addition, you can check the functionality, by checking DOM-elements. For example, you can open "favourite" tab and check that preset isn't there, then add it to "favourites" and check that it appears – no screenshot needed.
| import { turnOnMacromoleculesEditor } from '@utils/macromolecules'; | ||
| import { toggleRnaBuilderAccordion } from '@utils/macromolecules/rnaBuilder'; | ||
|
|
||
| async function gotoRNA(page: Page) { |
There was a problem hiding this comment.
I believe we already have this function somewhere. Can you move it to utils?
| @@ -31,9 +33,15 @@ export const RNAContextMenu = () => { | |||
| switch (id) { | |||
| case 'duplicateandedit': | |||
| props.duplicatePreset(activePresetForContextMenu); | |||
| if (selectedTabIndex !== 2) { | |||
There was a problem hiding this comment.
Let's use a constant/enum for this
| setActivePreset, | ||
| setIsEditMode, | ||
| } from 'state/rna-builder'; | ||
| import { scrollToSelectedPreset } from './RnaBuilder/RnaEditor/RnaEditor'; |
There was a problem hiding this comment.
Let's move styles to separate file?
| dispatch(createNewPreset()); | ||
| dispatch(setActiveRnaBuilderItem(RnaBuilderPresetsItem.Presets)); | ||
| } | ||
| }, [activePreset]); | ||
|
|
||
| const expandEditor = () => { | ||
| setExpanded(!expanded); | ||
| if (!activePreset.presetInList) { | ||
| if (!activePreset?.presetInList) { |
There was a problem hiding this comment.
Could you, please, also check the behaviour for editing presets?
- Just create any preset
- Click edit
- Try to change a name of preset
- Focus from input field is constantly lost after single character typing.
…ot-possible-to-add-rna-presets-into-the-favourite-library
StarlaStarla
force-pushed
the
3495-macro-is-not-possible-to-add-rna-presets-into-the-favourite-library
branch
from
0baf296 to
711a640
Compare
…ot-possible-to-add-rna-presets-into-the-favourite-library
…ot-possible-to-add-rna-presets-into-the-favourite-library
…ot-possible-to-add-rna-presets-into-the-favourite-library
…ot-possible-to-add-rna-presets-into-the-favourite-library
…ot-possible-to-add-rna-presets-into-the-favourite-library
…ot-possible-to-add-rna-presets-into-the-favourite-library
StarlaStarla
force-pushed
the
3495-macro-is-not-possible-to-add-rna-presets-into-the-favourite-library
branch
from
4612884 to
4c139de
Compare
…ot-possible-to-add-rna-presets-into-the-favourite-library
Nitvex
deleted the
3495-macro-is-not-possible-to-add-rna-presets-into-the-favourite-library
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Check list
#1234 – issue name