Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely replace yarn with npm commands throughout the project #2029

Closed
KonstantinEpam23 opened this issue Dec 29, 2022 · 0 comments · Fixed by #2126
Closed

Completely replace yarn with npm commands throughout the project #2029

KonstantinEpam23 opened this issue Dec 29, 2022 · 0 comments · Fixed by #2126
Assignees

Comments

@KonstantinEpam23
Copy link
Collaborator

KonstantinEpam23 commented Dec 29, 2022

Describe the solution you'd like
Completely replace yarn with npm commands throughout the project package.json files and any other script files that may rely on yarn.
This includes package.json scripts in all ./packages/* directories and in example apps:

./package.json
./packages/ketcher-react/package.json
./packages/ketcher-core/package.json
./packages/ketcher-standalone/package.json
./example/package.json

Each package and example need to be able to be built separately with npm and also together at the same time when build script is run from the project root.

Also, at the moment there are also some commands that are yarn-specific, e.g. the project is currently built via yarn foreach plugin: yarn workspaces foreach -ptvR --from ketcher-react-app run build
For such commands either npm alternatives or replacements need to be found.

In addition, yarn.lock file should be replaced with package-lock.json and husky scripts should be updated for local development.

As a result - the project should build correctly using only npm for both local development and deployment.

KonstantinEpam23 added a commit that referenced this issue Mar 16, 2023
KonstantinEpam23 added a commit that referenced this issue Mar 16, 2023
KonstantinEpam23 added a commit that referenced this issue Mar 24, 2023
KonstantinEpam23 added a commit that referenced this issue Mar 30, 2023
KonstantinEpam23 added a commit that referenced this issue Mar 30, 2023
KonstantinEpam23 added a commit that referenced this issue Mar 30, 2023
KonstantinEpam23 added a commit that referenced this issue Mar 30, 2023
…ct (#2126)

* 2029: Completely replace yarn with npm commands throughout the project

* #2029: fix audit

* #2029: fix audit command properly

* #2029: calrify devnotes

* #2029: move prerequisites in devnotes

* #2029 remove unused constant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants