Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2029: Completely replace yarn with npm commands throughout the project #2126

Conversation

KonstantinEpam23
Copy link
Collaborator

@KonstantinEpam23 KonstantinEpam23 commented Jan 25, 2023

@KonstantinEpam23 KonstantinEpam23 changed the base branch from master to 2008-move-from-yarn-to-npm January 25, 2023 10:06
@KonstantinEpam23 KonstantinEpam23 force-pushed the 2029-completely-replace-yarn-with-npm-commands-throughout-the-project branch 4 times, most recently from efd7824 to bc93043 Compare January 26, 2023 10:10
@KonstantinEpam23 KonstantinEpam23 self-assigned this Jan 26, 2023
@KonstantinEpam23 KonstantinEpam23 force-pushed the 2029-completely-replace-yarn-with-npm-commands-throughout-the-project branch from 657aa2d to 028e627 Compare January 26, 2023 10:22
@KonstantinEpam23 KonstantinEpam23 force-pushed the 2029-completely-replace-yarn-with-npm-commands-throughout-the-project branch 4 times, most recently from 4ce3ff1 to 8687479 Compare March 16, 2023 08:22
@KonstantinEpam23 KonstantinEpam23 changed the base branch from 2008-move-from-yarn-to-npm to master March 16, 2023 08:22
@KonstantinEpam23 KonstantinEpam23 marked this pull request as ready for review March 16, 2023 08:22
@KonstantinEpam23 KonstantinEpam23 force-pushed the 2029-completely-replace-yarn-with-npm-commands-throughout-the-project branch from 8687479 to bb0550f Compare March 16, 2023 08:27
DEVNOTES.md Outdated Show resolved Hide resolved
@AnastasiiaPlyako
Copy link
Collaborator

I think we also can update read.me files in packages/ketcher-core etc

@KonstantinEpam23
Copy link
Collaborator Author

I think we also can update read.me files in packages/ketcher-core etc

Well, for people who use our packages as npm modules - we don't really care if they use npm or yarn, they should work for both. These changes are mainly for people who work with the repository directly (like us 😄 )

@KonstantinEpam23 KonstantinEpam23 linked an issue Mar 17, 2023 that may be closed by this pull request
@papillot
Copy link

Thank-you for looking into this. For what it's worth, I've tried to run npm install using this branch (npm install --save "https://github.com/epam/ketcher.git#2029-completely-replace-yarn-with-npm-commands-throughout-the-project") and it ultimately failed at the post-install step where husky install is invoked, because husky is not part of the regular dependencies.
Here is the relevant part of the npm install logs:

329 error command failed
330 error command sh -c husky install
331 error sh: husky: command not found

@KonstantinEpam23 KonstantinEpam23 force-pushed the 2029-completely-replace-yarn-with-npm-commands-throughout-the-project branch from e29ee04 to 30646ce Compare March 30, 2023 16:57
@KonstantinEpam23 KonstantinEpam23 merged commit f227127 into master Mar 30, 2023
@KonstantinEpam23 KonstantinEpam23 deleted the 2029-completely-replace-yarn-with-npm-commands-throughout-the-project branch March 30, 2023 17:42
@KonstantinEpam23 KonstantinEpam23 linked an issue Mar 30, 2023 that may be closed by this pull request
@KonstantinEpam23
Copy link
Collaborator Author

Hello @papillot , thank you checking this PR and pointing this out! I believe you are correct about the reason that the error appears b/c the library is not part of the non-dev builds.
Currently ketcher is mostly oriented on using its separate packages (ketcher-core, ketcher-react, etc) and building your own app (e.g. using the /example or /demo directories from the repository)

In the future we may be looking to avoiding using husky for non-dev builds.
Hopefully this clarifies things a bit, thank you for your input again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants