Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine s-group menus and remove generic s-group #2093

Closed
AlexanderSavelyev opened this issue Jan 13, 2023 · 0 comments · Fixed by #2140
Closed

Combine s-group menus and remove generic s-group #2093

AlexanderSavelyev opened this issue Jan 13, 2023 · 0 comments · Fixed by #2140
Assignees
@yuleicul
Labels
feature request Priority: High
Milestone
Ketcher 2.9.0-rc.1

Comments

@AlexanderSavelyev
Copy link
Contributor

AlexanderSavelyev commented Jan 13, 2023 •
edited by Zhirnoff
Loading

Background
The terms and navigation are not intuitive if you're not intimately familiar with all of the terms. Consider ways to either update the terms or provide more detailed help menus.

Solution

  • Keep only one single s-group menu. Use the icon from "S-group" on the left
  • Remove S-Group type Generic
  • Add Data S-Group type
  • The following types should be available with the order: [Data, Multiple group, SRU polymer, Superatom]
  • If user selects "Data" type then data s-group menu should be added with additional fields (similar to the current "Data s-group"): Context, Field name, Field value, Absolute, Relative, Attached. For all other types fields should be the same as currently

#183715563
@yuleicul yuleicul mentioned this issue Jan 30, 2023
Merged
@yuleicul yuleicul assigned yuleicul and unassigned Nitvex Jan 30, 2023
yuleicul added a commit that referenced this issue Feb 6, 2023
@yuleicul
Merge branch 'master' into #2093-combine-s-group-menus-and-remove-gen…
6f8b3cf 
…eric-s-group
yuleicul added a commit that referenced this issue Feb 9, 2023
@yuleicul
Merge branch 'master' into #2093-combine-s-group-menus-and-remove-gen…
580c95d 
…eric-s-group
KonstantinEpam23 pushed a commit that referenced this issue Feb 10, 2023
@yuleicul
#2093 combine s group menus and remove generic s group (#2140)
b6139d7 
* Combine sdata to sgroup modal

* Remove s-group data from left toolbar

* Remove Data S-Group modal

* Make code more readable
ansivgit pushed a commit that referenced this issue Feb 22, 2023
@yuleicul @ansivgit
#2093 combine s group menus and remove generic s group (#2140)
2ff582d 
* Combine sdata to sgroup modal

* Remove s-group data from left toolbar

* Remove Data S-Group modal

* Make code more readable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuleicul yuleicul

Labels
feature request Priority: High
Projects
None yet
Milestone
Ketcher 2.9.0-rc.1
Development

Successfully merging a pull request may close this issue.

#2093 combine s group menus and remove generic s group epam/ketcher
4 participants
@AlexanderSavelyev @yuleicul @Nitvex @Zhirnoff