#2093 combine s group menus and remove generic s group #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitvex
reviewed
Feb 8, 2023
| (prop) => prop !== 'type' && prop !== 'context' && prop !== 'fieldName' | ||
| ) | ||
| .map((prop) => { | ||
| return prop === 'radiobuttons' ? ( |
There was a problem hiding this comment.
I propose to don't use two nested ternary operators.
| Object.keys(schemes[type].properties) | ||
| .filter((prop) => prop !== 'type') | ||
| .map((prop) => { | ||
| const props = {} |
There was a problem hiding this comment.
Small proposal, may be the following can be better:
if (sGroupProperty === 'connectivity') {
<Field
name={prop}
key={`${type}-${prop}`}
{...props}
component={Select}
options={getSelectOptionsFromSchema(schemes[type].properties[prop])}
/>
}
const propsMapping = {
name: { maxLength: 15 },
fieldName: { maxLength: 30 },
fieldValue: { type: 'textarea' },
radiobuttons: { type: 'radio' }
}
const props = propsMapping[sGroupProperty] || {}
return <Field name={prop} key={`${type}-${prop}`} {...props} />
There was a problem hiding this comment.
Done. Really good suggestions, thank you so much.
Nitvex
approved these changes
Feb 9, 2023
KonstantinEpam23
approved these changes
Feb 10, 2023
KonstantinEpam23
deleted the
#2093-combine-s-group-menus-and-remove-generic-s-group
branch
ansivgit
pushed a commit
that referenced
this pull request
Feb 22, 2023
* Combine sdata to sgroup modal * Remove s-group data from left toolbar * Remove Data S-Group modal * Make code more readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2093
For reviewers:
Before:
After:
More details: https://excalidraw.com/#json=akG_vHaNa4J29lFtRzbSY,eFq4Q1LGavcpuj25tG3Mtw