Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Save button is active for empty canvas #2196

Closed
lorken24 opened this issue Feb 9, 2023 · 0 comments · Fixed by #2579
Closed

The Save button is active for empty canvas #2196

lorken24 opened this issue Feb 9, 2023 · 0 comments · Fixed by #2579
Assignees
@gairon
Labels
bug
Milestone
Ketcher 2.11.0-rc.1

Comments

@lorken24
Copy link
Collaborator

lorken24 commented Feb 9, 2023 •
edited
Loading

Steps to Reproduce

  1. Open Ketcher
  2. With the empty canvas click on the 'Save as.." button

Actual behavior
Save structure displaying active 'Save" button

Expected behavior
When the canvas is empty, the "Save" button is disabled

Screenshots

Screen.Recording.2023-02-09.at.14.09.29.mov

Desktop:

  • OS: MacOS 13.2
  • Browser Chrome
  • Version 109.0.5414.119 (Official Build) (arm64)

Ketcher version
v2.8.0
@lorken24 lorken24 added the bug label Feb 9, 2023
@lorken24 lorken24 added this to the Refined Backlog milestone Feb 9, 2023
@gairon gairon self-assigned this May 5, 2023
gairon added a commit that referenced this issue May 8, 2023
@gairon
#2196 - the Save button is active for empty canvas
daf2deb 
* Fix disabled prop for SaveButton
* Add tests for disabled prop
@gairon gairon linked a pull request May 8, 2023 that will close this issue
#2196 - the Save button is active for empty canvas #2579
Merged
gairon added a commit that referenced this issue May 8, 2023
@gairon
#2196 - the Save button is active for empty canvas
a229fab 
* Fix disabled prop for SaveButton
* Add tests for disabled prop
gairon added a commit that referenced this issue May 9, 2023
@gairon
#2196 - the Save button is active for empty canvas (#2579)
dd2e2a0 
* #2196 - the Save button is active for empty canvas
* Fix disabled prop for SaveButton
* Add tests for disabled prop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gairon gairon

Labels
bug
Projects
None yet
Milestone
Ketcher 2.11.0-rc.1
Development

Successfully merging a pull request may close this issue.

#2196 - the Save button is active for empty canvas epam/ketcher
4 participants
@gairon @Nitvex @lorken24 @KonstantinEpam23