Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2196 - the Save button is active for empty canvas #2579

Merged
merged 2 commits into from
May 9, 2023
Merged

#2196 - the Save button is active for empty canvas #2579

merged 2 commits into from
May 9, 2023

Conversation

gairon
Copy link
Contributor

@gairon gairon commented May 8, 2023

  • Fix disabled prop for SaveButton component
  • Add tests for disabled prop

@gairon
#2196 - the Save button is active for empty canvas
daf2deb 
* Fix disabled prop for SaveButton
* Add tests for disabled prop
@auto-assign auto-assign bot requested review from Nitvex and a user May 8, 2023 08:14
@Nitvex Nitvex requested a review from VasilevDO May 8, 2023 08:14
@gairon gairon linked an issue May 8, 2023 that may be closed by this pull request
The Save button is active for empty canvas #2196
Closed
@gairon
#2196 - the Save button is active for empty canvas
a229fab 
* Fix disabled prop for SaveButton
* Add tests for disabled prop
yuleicul
yuleicul approved these changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@yuleicul yuleicul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Learned setupFilesAfterEnv from your code. Thank you!

@gairon gairon merged commit dd2e2a0 into master May 9, 2023
@gairon gairon deleted the #2196-the-save-button-is-active-for-empty-canvas branch May 9, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuleicul yuleicul yuleicul approved these changes

@Nitvex Nitvex Awaiting requested review from Nitvex

@VasilevDO VasilevDO Awaiting requested review from VasilevDO

Assignees

@gairon gairon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Save button is active for empty canvas
2 participants
@gairon @yuleicul