Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2196 - the Save button is active for empty canvas #2579

Merged
merged 2 commits into from
May 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/ketcher-react/jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,6 @@ module.exports = {
moduleNameMapper: {
'\\.(css|less)$': 'identity-obj-proxy',
'src(.*)$': '<rootDir>/src/$1'
}
},
setupFilesAfterEnv: ['<rootDir>/src/setupTests.ts']
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import React from 'react'
import { fireEvent, render, screen, waitFor } from '@testing-library/react'
import '@testing-library/jest-dom'
import userEvent from '@testing-library/user-event'

import ColorPicker from './ColorPicker'
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
/****************************************************************************
* Copyright 2021 EPAM Systems
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
***************************************************************************/

import { render, screen } from '@testing-library/react'
import { SaveButton } from './savebutton'

jest.mock('../../../../hooks', () => {
return {
...jest.requireActual('../../../../hooks'),
useAppContext: () => ({
getKetcherInstance: () => null
})
}
})

jest.mock('ketcher-core')

describe('SaveButton', () => {
const defaultProps = {
filename: 'test.mol',
data: ''
}

describe('Disabled state', () => {
it('Should be enabled by default', () => {
render(<SaveButton {...defaultProps}>Save</SaveButton>)
const btn = screen.getByRole('button')
expect(btn).toBeEnabled()
})

it('Should be disabled', () => {
render(
<SaveButton {...defaultProps} disabled>
Save
</SaveButton>
)
const btn = screen.getByRole('button')
expect(btn).toBeDisabled()
})
})
})
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ type Props = {
onError?: (err: any) => void
className?: string
title?: string
disabled?: boolean
}

type FileSaverReturnType = Promise<
Expand All @@ -51,7 +52,8 @@ const SaveButton = (props: SaveButtonProps) => {
onSave = noop,
onError = noop,
className,
title
title,
disabled
} = props
const { getKetcherInstance } = useAppContext()

Expand Down Expand Up @@ -99,6 +101,7 @@ const SaveButton = (props: SaveButtonProps) => {
<button
title={title}
className={className}
disabled={disabled}
onClick={(event) => {
save(event)
}}
Expand Down
1 change: 1 addition & 0 deletions packages/ketcher-react/src/setupTests.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
import '@testing-library/jest-dom'